Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73397 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 65421 invoked from network); 25 Mar 2014 00:24:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Mar 2014 00:24:44 -0000 Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.170 as permitted sender) X-PHP-List-Original-Sender: tjerk.meesters@gmail.com X-Host-Fingerprint: 209.85.128.170 mail-ve0-f170.google.com Received: from [209.85.128.170] ([209.85.128.170:34685] helo=mail-ve0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0B/E0-60997-ACCC0335 for ; Mon, 24 Mar 2014 19:24:43 -0500 Received: by mail-ve0-f170.google.com with SMTP id pa12so6669600veb.29 for ; Mon, 24 Mar 2014 17:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=c9t6PhWIPboMtAP5H9azZsvK1VZv3C0mT/WiG/KRu3U=; b=GxTgvvQnCOH+inuGF9CTHA2eQAkbFQMEayDfBwHabxnoXnIlpPv2tiIrpCTbVZiA4Y OxQCbz1aDHUiArUU+ixagODi9d39WrxA/Ffb1r/ent6/vDNErRj/LrhpcXhqOVqFE7p1 tUkAAJMjHfmMjyAoJ8J0go3taiQxrd7jFbd2Ay3WiHYe0b5xpUSArc+5TWZdEH7f4KoJ vfHvgayeAliyrbenOWYYFn5O0p2IX9i3uNPvF95Lpukj1sQahO7HUTliwRXp65d1Xljs tNvNFWDVYQEfNn9/rpq5JAqgtmqcPPyeAdf56rnhH/HO2WI2pKS9vfkP1jGqHxsje5Fe 3l/w== MIME-Version: 1.0 X-Received: by 10.58.165.68 with SMTP id yw4mr53966490veb.17.1395707080360; Mon, 24 Mar 2014 17:24:40 -0700 (PDT) Received: by 10.58.55.131 with HTTP; Mon, 24 Mar 2014 17:24:40 -0700 (PDT) In-Reply-To: References: <532A3E88.20202@sugarcrm.com> <532A418A.8020607@sugarcrm.com> <532B4A1B.5090503@sugarcrm.com> <532B6581.6030801@sugarcrm.com> <532B91AF.7090804@sugarcrm.com> Date: Tue, 25 Mar 2014 08:24:40 +0800 Message-ID: To: Stas Malyshev Cc: Etienne Kneuss , PHP Internals Content-Type: multipart/alternative; boundary=047d7b677702bd358e04f563606c Subject: Re: [PHP-DEV] Merge PR 621 From: tjerk.meesters@gmail.com (Tjerk Meesters) --047d7b677702bd358e04f563606c Content-Type: text/plain; charset=ISO-8859-1 Hi Stas, On Fri, Mar 21, 2014 at 10:48 AM, Tjerk Meesters wrote: > Hi Stas, > > On Fri, Mar 21, 2014 at 9:11 AM, Stas Malyshev wrote: > >> Hi! >> >> > It seems that PR 614 covers exactly that; it uses the check_empty flag >> > within spl_array_has_dimension_ex() to make sure offsetGet() is called >> > when needed. >> >> I understand that the problem may be that check_empty is not sent on >> isset? Didn't verify that though. >> > > It does, as can be seen here: > > http://lxr.php.net/xref/PHP_5_6/Zend/zend_vm_def.h#4737 > > The check_empty argument value is ternary, meaning it can be 0 (isset), 1 > (empty) or 2 (key exists). > > Having looked it over I realized that my older patch had some issues; I've > addressed those and reopened #614. > Do you have any issues with the code as it stands now? https://github.com/php/php-src/pull/614 It's currently targeted at 5.4; if there are any objections to that I'll move the changes to 5.6 instead. > > I've closed #621. > > >> -- >> Stanislav Malyshev, Software Architect >> SugarCRM: http://www.sugarcrm.com/ >> (408)454-6900 ext. 227 >> > > > > -- > -- > Tjerk > -- -- Tjerk --047d7b677702bd358e04f563606c--