Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73380
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain student.uws.edu.au from 213.199.154.12 cause and error)
To: Yasuo Ohgaki <yohgaki@ohgaki.net>, Stas Malyshev <smalyshev@sugarcrm.com>
CC: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] Re: Session: deprecating create_sid() method and add
 createSid()?
Thread-Index: AQHPQijxOLqyaJ4nAk6Vu2MJBoQyrJrl4eEAgAAaj4CAAHrtgIABEykAgAjWMjs=
Date: Mon, 24 Mar 2014 15:07:29 +0000
Message-ID: <4ddbce0e2545417b947c864da031319b@SINPR01MB154.apcprd01.prod.exchangelabs.com>
References: <CAGa2bXb09KO-ydd-vf3rJMR=pjQZ=1kG0Qq+snLoKPEL+Fp6XQ@mail.gmail.com>
 <CAGa2bXZGK06+aqe3HOEo9BC2R71a8HaBCqjBn=g_RbEK6u-Uqw@mail.gmail.com>
 <53277BE2.8020203@sugarcrm.com>
 <CAGa2bXadowN=wdxizXXLgOEB5pZArdAOEs653U-=5AkAcg6_4Q@mail.gmail.com>
 <5327F947.5020308@sugarcrm.com>,<CAGa2bXY3GbsZWTwPQcjun+JiPX=nWZVrQ5rpt-ecyva4iJ=Mxw@mail.gmail.com>
In-Reply-To: <CAGa2bXY3GbsZWTwPQcjun+JiPX=nWZVrQ5rpt-ecyva4iJ=Mxw@mail.gmail.com>
Accept-Language: en-AU, en-GB, en-US
Content-Language: en-AU
received-spf: None (: student.uws.edu.au does not designate permitted sender
 hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: RE: [PHP-DEV] Re: Session: deprecating create_sid() method and add
 createSid()?
From: 17260015@student.uws.edu.au (Rajneesh Shetty)

"If you
would like, I can
add similar change to 5.5." My question is how do clearances work in this g=
roup?

Rajneesh N. Shetty
Tel : (+61)468371858
________________________________________
From: yohgaki@gmail.com [yohgaki@gmail.com] on behalf of Yasuo Ohgaki [yohg=
aki@ohgaki.net]
Sent: Wednesday, 19 March 2014 11:08 AM
To: Stas Malyshev
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] Re: Session: deprecating create_sid() method and add=
 createSid()?

Hi Stas,

On Tue, Mar 18, 2014 at 4:44 PM, Stas Malyshev <smalyshev@sugarcrm.com>wrot=
e:

> > What is your opinion?
>
> My opinion it would be the best if we could support both and deprecate
> create_sid in 5.6, but if it's hard to do cleanly, then leave it alone.
>

I've included createSid() definition in
https://github.com/php/php-src/pull/628/

If create_sid() is defined, it's used. If both create_sid() and createSid()
is defined, createSid()
is used.

SessionHandler does not use new SessionUpdateTimestampHandlerInterface, so
user may
choose what they would do about create_sid() and createSid(). Current
session module's
object handling is some what legacy, so such thing can be done.

I think this is the best way. We can keep compatibility and have standard
confirming createSid()
name. Since it keeps compatibility with 5.5, we may leave 5.5 alone. If you
would like, I can
add similar change to 5.5.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net=