Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73361
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAL+t6cHOiBro=PUJnrA_n_iP_96KuXnrsVFX10ymONMPiAJW2g@mail.gmail.com>
References: <CAO6UHD40eL2eW9T_1mtTnnxcBavSkV51nZ_uTLLc9nWYCbxo=w@mail.gmail.com>
	<CAL+t6cHOiBro=PUJnrA_n_iP_96KuXnrsVFX10ymONMPiAJW2g@mail.gmail.com>
Date: Sat, 22 Mar 2014 11:13:51 -0400
Message-ID: <CAO6UHD4tH+hR8eRdWwkPN7o-4Cgys_nvvksbsKkQ8cmghRF0cw@mail.gmail.com>
To: Sherif Ramadan <theanomaly.is@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d0443041638624a04f53373a6
Subject: Re: [PHP-DEV] Pull Request #595
From: cwscribner@gmail.com (Chad Scribner)

--f46d0443041638624a04f53373a6
Content-Type: text/plain; charset=ISO-8859-1

Awesome, thank you very much!

I'll have to do some more code spelunking to figure out the macros
mentioned in the PR comments as I'm still new to the code base.  If/when I
put the comments into action, should I update my PR or create a new one?
On Mar 22, 2014 11:04 AM, "Sherif Ramadan" <theanomaly.is@gmail.com> wrote:

>
>
>
> On Fri, Mar 21, 2014 at 10:29 PM, Chad Scribner <cwscribner@gmail.com>wrote:
>
>> Hello All,
>>
>> I'm here to request that my pull request #595 get merged.  It's a fix for
>> bug #52384 regarding PDO::debugDumpParams().  I've put the code and a phpt
>> into the PR.  You'll notice in the PR that the Travis CI build failed but
>> after investigating, my test did not fail.  It looks as though it was due
>> to other code.  This is my first time making a contribution so feel free
>> to
>> let me know if there's anything else I need to add.  Thanks!
>>
>> ~Chad
>>
>
>
> Hey Chad,
>
> I took a look at your PR some time ago, I believe. Sorry, I did not have
> the time to merge it last time being so busy with work, but it looks good.
> I saw a few useful comments on the PR on github by nikic and datibbaw.
> Maybe take those under consideration. I'll be happy to merge it, though, if
> no one else does by tomorrow night.
>

--f46d0443041638624a04f53373a6--