Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73354
Return-Path: <julienpauli@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 848 invoked from network); 21 Mar 2014 10:41:42 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 Mar 2014 10:41:42 -0000
Authentication-Results: pb1.pair.com header.from=julienpauli@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=julienpauli@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.171 as permitted sender)
X-PHP-List-Original-Sender: julienpauli@gmail.com
X-Host-Fingerprint: 209.85.220.171 mail-vc0-f171.google.com  
Received: from [209.85.220.171] ([209.85.220.171:41941] helo=mail-vc0-f171.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id CB/55-65185-5671C235 for <internals@lists.php.net>; Fri, 21 Mar 2014 05:41:41 -0500
Received: by mail-vc0-f171.google.com with SMTP id lg15so2376628vcb.16
        for <internals@lists.php.net>; Fri, 21 Mar 2014 03:41:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date:message-id
         :subject:to:cc:content-type;
        bh=BoDcyf6vInIYGbduY1G3CXVI4zym5CYrvMLFMRj4GB0=;
        b=cFQ3645EePiKuFtZarwUR8qBKG9HIPxQPxBCuTJmNBSZCpmvQ1tVc0KzOGoFQJo5qO
         L2skJWEVEWimcizk/xuo+VGwBABWJR7MfUEfTLVhKD4G2ljLxUzsHR9Lv23K8pQuDq44
         GbKCwXtcN6qxHTIvKTofZhplnzRbMaW/BjT61uutxnOfPi9syYckBYUaIXIpyxyOauwW
         yrwNYXyDTcoBHfJ9q+moW4XzOTogiUnY0HfX3QciJt21FYIfufXF/QwnMEl6jyV7u1DM
         xOP27V/pHhD6qmog6NwUtZUgjFjU+8x1zyRRKKYLpku66lotn6PlCGLvftRfDCWRXY2j
         o8lg==
X-Received: by 10.52.108.228 with SMTP id hn4mr5910318vdb.43.1395398498504;
 Fri, 21 Mar 2014 03:41:38 -0700 (PDT)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
Received: by 10.220.81.68 with HTTP; Fri, 21 Mar 2014 03:40:58 -0700 (PDT)
In-Reply-To: <CAGa2bXYO6s6sQo0UkuRSaSciU1XVCHhWqc5MHCDL1H15ChZ65Q@mail.gmail.com>
References: <CAMUwpuSVE4iMA86bxXUnvYLonJ3xmDZ_QSzM38eNvJibxcv6Xw@mail.gmail.com>
 <CAGa2bXYO6s6sQo0UkuRSaSciU1XVCHhWqc5MHCDL1H15ChZ65Q@mail.gmail.com>
Date: Fri, 21 Mar 2014 11:40:58 +0100
X-Google-Sender-Auth: tr7eR8QsnVM8r_O47E7AnMSuvkE
Message-ID: <CAMUwpuQePpm3FLY27ptvPyBU=kndK805D8sRr5N3GSoTQiiGxw@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: PHP Internals <internals@lists.php.net>, Andrey Andreev <narf@devilix.net>
Content-Type: multipart/alternative; boundary=bcaec548a8e9d2d46504f51b8702
Subject: Re: session_reset() and session_abort() to send errors
From: jpauli@php.net (Julien Pauli)

--bcaec548a8e9d2d46504f51b8702
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Mar 21, 2014 at 12:57 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi Julien,
>
> On Fri, Mar 21, 2014 at 1:01 AM, Julien Pauli <jpauli@php.net> wrote:
>
>> I was just reviewing the new code and functions in 5.6 for session module.
>>
>> I noticed that session_reset() and session_abort() came in.
>>
>> I would suggest those functions to throw errors when the session is not
>> initialized.
>>
>> This is already done for all other session related functions
>> (session_reset_id(), session_regenerate_id(), session_destroy()).
>>
>> Thoughts ?
>>
>
> I agree and they should.
> I'll take care of them or anyone else?
> It will be few days later.
>

You can go for it, I have no git connection today :-p

Thank you !

Julien

--bcaec548a8e9d2d46504f51b8702--