Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73352 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 66529 invoked from network); 21 Mar 2014 02:48:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Mar 2014 02:48:51 -0000 Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.182 as permitted sender) X-PHP-List-Original-Sender: tjerk.meesters@gmail.com X-Host-Fingerprint: 209.85.220.182 mail-vc0-f182.google.com Received: from [209.85.220.182] ([209.85.220.182:58014] helo=mail-vc0-f182.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D9/10-65185-298AB235 for ; Thu, 20 Mar 2014 21:48:51 -0500 Received: by mail-vc0-f182.google.com with SMTP id ks9so2023432vcb.13 for ; Thu, 20 Mar 2014 19:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=RZ9NpW2PIysTMBYOGfLxhQ50V6O0qaAi97o/oR8brXg=; b=w0KHrmaDq+E/GOmQJFFxKcNfTKGiN0RBEc0sA6Ou4mZ6LEm89lnLHXAZkKdn3ytyX1 yYznLBSJRUj7E5y08ufSYLXQYQ4VWmfyL6p7Qeh2H92CSFcpwTQsIFUULqaMSkohDlPd F/R1qNkMLeLaa6TDKvRggWPMgSfzlalT5UoCy/q4uI7tkEj4yc37bbxwsMYVeZ6yPlvi JNVSPMEReKgC3vmpnFSXY7mgUNsgCytI8ygW5BUow9WXrozkyOW17EOHdbKoSD7ZbnNr nGlnjHHEvZSZ9/a5ncZ3FDBy6NFPXlkyyULVJnvNZtarPTmGif+SRqpdmw1bDqgaRsSc V8xA== MIME-Version: 1.0 X-Received: by 10.59.9.38 with SMTP id dp6mr15633150ved.24.1395370128609; Thu, 20 Mar 2014 19:48:48 -0700 (PDT) Received: by 10.58.55.131 with HTTP; Thu, 20 Mar 2014 19:48:48 -0700 (PDT) In-Reply-To: <532B91AF.7090804@sugarcrm.com> References: <532A3E88.20202@sugarcrm.com> <532A418A.8020607@sugarcrm.com> <532B4A1B.5090503@sugarcrm.com> <532B6581.6030801@sugarcrm.com> <532B91AF.7090804@sugarcrm.com> Date: Fri, 21 Mar 2014 10:48:48 +0800 Message-ID: To: Stas Malyshev Cc: Etienne Kneuss , PHP Internals Content-Type: multipart/alternative; boundary=047d7bf0f4fcd89ab704f514ec62 Subject: Re: [PHP-DEV] Merge PR 621 From: tjerk.meesters@gmail.com (Tjerk Meesters) --047d7bf0f4fcd89ab704f514ec62 Content-Type: text/plain; charset=ISO-8859-1 Hi Stas, On Fri, Mar 21, 2014 at 9:11 AM, Stas Malyshev wrote: > Hi! > > > It seems that PR 614 covers exactly that; it uses the check_empty flag > > within spl_array_has_dimension_ex() to make sure offsetGet() is called > > when needed. > > I understand that the problem may be that check_empty is not sent on > isset? Didn't verify that though. > It does, as can be seen here: http://lxr.php.net/xref/PHP_5_6/Zend/zend_vm_def.h#4737 The check_empty argument value is ternary, meaning it can be 0 (isset), 1 (empty) or 2 (key exists). Having looked it over I realized that my older patch had some issues; I've addressed those and reopened #614. I've closed #621. > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > -- -- Tjerk --047d7bf0f4fcd89ab704f514ec62--