Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73350 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55519 invoked from network); 20 Mar 2014 23:58:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Mar 2014 23:58:44 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.180 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.217.180 mail-lb0-f180.google.com Received: from [209.85.217.180] ([209.85.217.180:45087] helo=mail-lb0-f180.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 30/00-55483-3B08B235 for ; Thu, 20 Mar 2014 18:58:43 -0500 Received: by mail-lb0-f180.google.com with SMTP id 10so1170851lbg.11 for ; Thu, 20 Mar 2014 16:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=8d/XYpkSLdWdm3wH5wYaKdT+VJcwiY/uEtDZbmuBSOs=; b=bp85XEYaIZYETV0vbWbkKU/P9FDY7wGa/pKmk+B++ZwuXEoUMFXAqLZdn4+AncNrqT 2A7a4zX5m2TWa3LNAbAWmoLfYZ4o2+l/KFCyTNXk8h+xyDxGnPu1722BZN+Xrupx/48e xG6ELrFEDbv5wLk5gOikwc11CkNVliZFkE3DSIXQZRag0Zqe1Mh2FnqtWQuQxa0d8Wf0 a9XMv2QegnRvigEdnaY3UvR5gd+X+R0nxE39PQbemggSl2Zm6BLd/ZvwsY3V1hCQxjDz 6UeJ0tYo9C/BE8UWLhNoG9eLNshHzJe+IQpOL8VtJq5S3hTF0syESOyPvwmrdc01VLE1 njGA== X-Received: by 10.152.120.168 with SMTP id ld8mr31861554lab.12.1395359920013; Thu, 20 Mar 2014 16:58:40 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.205.73 with HTTP; Thu, 20 Mar 2014 16:57:59 -0700 (PDT) In-Reply-To: References: Date: Fri, 21 Mar 2014 08:57:59 +0900 X-Google-Sender-Auth: A67p_SGnQ_zG5_NDVS3He2n9yJs Message-ID: To: Julien Pauli Cc: PHP Internals , Andrey Andreev Content-Type: multipart/alternative; boundary=089e012281a45dc85204f5128cac Subject: Re: session_reset() and session_abort() to send errors From: yohgaki@ohgaki.net (Yasuo Ohgaki) --089e012281a45dc85204f5128cac Content-Type: text/plain; charset=UTF-8 Hi Julien, On Fri, Mar 21, 2014 at 1:01 AM, Julien Pauli wrote: > I was just reviewing the new code and functions in 5.6 for session module. > > I noticed that session_reset() and session_abort() came in. > > I would suggest those functions to throw errors when the session is not > initialized. > > This is already done for all other session related functions > (session_reset_id(), session_regenerate_id(), session_destroy()). > > Thoughts ? > I agree and they should. I'll take care of them or anyone else? It will be few days later. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --089e012281a45dc85204f5128cac--