Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73349
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <532B6581.6030801@sugarcrm.com>
References: <CAHMUw2EeYA3m4QnRtLYm1PRa3taGiS8Sx5GxdN==ZYTQoFV=vQ@mail.gmail.com>
	<532A3E88.20202@sugarcrm.com>
	<ECAD39ED-2A1D-4B54-80D5-4CB4FBA71364@gmail.com>
	<532A418A.8020607@sugarcrm.com>
	<CACQesk74e3=FNd4KgC4XDHXiq97yk8KXRXAvV3tqRWOzFwN_pw@mail.gmail.com>
	<532B4A1B.5090503@sugarcrm.com>
	<CACQesk5W8H+NuZVeUprDOMK26szTQYtHFeT5XoWwYXLCb-8=Vw@mail.gmail.com>
	<532B6581.6030801@sugarcrm.com>
Date: Fri, 21 Mar 2014 07:23:11 +0800
Message-ID: <CAHMUw2Ff0cQjudC0tdJ+6y8ybsuFQ9qN6kdZ0kbKbfAcQG3jWA@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Etienne Kneuss <colder@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b6d8e608440b504f5120de2
Subject: Re: [PHP-DEV] Merge PR 621
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--047d7b6d8e608440b504f5120de2
Content-Type: text/plain; charset=ISO-8859-1

Hi Stas,

On Fri, Mar 21, 2014 at 6:02 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> > The important part is that isset() triggers read_dimension and
> > eventually offsetGet() for isset(), and we seem to agree on that.
>
> Yes, agreed. Unfortunately, I'll be busy till the next week so couldn't
> propose a fix, but if nobody beats me to it I'll look at it next week.
>

It seems that PR 614 covers exactly that; it uses the check_empty flag
within spl_array_has_dimension_ex() to make sure offsetGet() is called when
needed.

https://github.com/php/php-src/pull/614

Was there something I missed there? I'm happy to work on this :)


> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>



-- 
--
Tjerk

--047d7b6d8e608440b504f5120de2--