Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73312
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.53 as permitted sender)
References: <CAHMUw2EeYA3m4QnRtLYm1PRa3taGiS8Sx5GxdN==ZYTQoFV=vQ@mail.gmail.com> <532A3E88.20202@sugarcrm.com>
Mime-Version: 1.0 (1.0)
In-Reply-To: <532A3E88.20202@sugarcrm.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-ID: <ECAD39ED-2A1D-4B54-80D5-4CB4FBA71364@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Date: Thu, 20 Mar 2014 09:13:24 +0800
To: Stas Malyshev <smalyshev@sugarcrm.com>
Subject: Re: [PHP-DEV] Merge PR 621
From: tjerk.meesters@gmail.com (Tjerk Meesters)

Hi Stas,

> On 20 Mar, 2014, at 9:04 am, Stas Malyshev <smalyshev@sugarcrm.com> wrote:=

>=20
> Hi!
>=20
>> https://github.com/php/php-src/pull/621
>>=20
>> It makes isset() and empty() call offsetGet() on objects that extend
>> ArrayObject if offsetExists() returns TRUE.
>=20
> Looks at this patch, isn't that what check_empty parameter was supposed
> to be doing? Why doesn't it work and it needs to be moved to opcodes?

Yes, that's probably what it was supposed to do, but as you can see from bug=
 66834 that's clearly not the case. I had earlier approached the problem pur=
ely from SPL standpoint (see linked PR) but Etienne said that it would be a b=
etter idea to tackle this issue further up the chain so to speak :)

>=20
> --=20
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227