Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73311 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35470 invoked from network); 20 Mar 2014 01:04:13 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Mar 2014 01:04:13 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.67 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.67 smtp67.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.67] ([108.166.43.67:38542] helo=smtp67.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 99/70-33112-C8E3A235 for ; Wed, 19 Mar 2014 20:04:12 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp1.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 23E77148A08; Wed, 19 Mar 2014 21:04:09 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp1.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id D61571489FC; Wed, 19 Mar 2014 21:04:08 -0400 (EDT) Message-ID: <532A3E88.20202@sugarcrm.com> Date: Wed, 19 Mar 2014 18:04:08 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Tjerk Meesters , PHP Internals References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Merge PR 621 From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > https://github.com/php/php-src/pull/621 > > It makes isset() and empty() call offsetGet() on objects that extend > ArrayObject if offsetExists() returns TRUE. Looks at this patch, isn't that what check_empty parameter was supposed to be doing? Why doesn't it work and it needs to be moved to opcodes? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227