Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73282
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.160.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYnvFz-MtH21+vg=3siAsK_uTndUNCptCkozW=OarGJ9A@mail.gmail.com>
References: <CAPhkiZw5xWRkc=ofh-nB5ZkjfThZFkH_+pK5RZaQFLKhno7u7A@mail.gmail.com>
	<CAGa2bXZiBuw_L_ehvTZb5_UUedtbS0n4GXYUjtKix0S9DX_8KQ@mail.gmail.com>
	<5324FE40.1070704@sugarcrm.com>
	<CAPhkiZy1oG_WHijMknB34dyo0aZRDU89EBafpaEGqGM32DCK0A@mail.gmail.com>
	<532603A0.8060802@sugarcrm.com>
	<CAPhkiZxdrxiKT3cTW9ra=0aFDKKP3-OpjmGdxqzHxu8YEUK2ww@mail.gmail.com>
	<CAGa2bXbH8WFp=8C-ON-1aAHLiyTsemVKMH+dGnqBSJAw5zw-GA@mail.gmail.com>
	<CAPhkiZx52CiKkk385itjEtg99ox3PHzXga9ZWDPbWiB2wRyH4g@mail.gmail.com>
	<CAGa2bXZGun=khdMZHzYoERap7qj7bQDPEfQzx2jJ2MwPs7-p_g@mail.gmail.com>
	<CAPhkiZzmzTqPR4KynBCWijvHa=TGKzTni7JdfuuKdy_i=sBeQg@mail.gmail.com>
	<CAGa2bXb6k8NYyYheCM6dvFWj-jA2GLP7ZiusTgZK-YgkNkeHhQ@mail.gmail.com>
	<CAPhkiZz-_PxvfsCiMDm8Hf9YzVNV+Ch1zpqDut19uV1w1WCWoA@mail.gmail.com>
	<CAGa2bXb45BizZ8g8zzdneV_27R7zgiX34xoZm+f8YyNQrZxdTQ@mail.gmail.com>
	<CAPhkiZxi0UxrrUMRNUFDmkzs2pX6y81PPabzLjLF-ChboaB8jg@mail.gmail.com>
	<CAGa2bXYajPoD6D34nPXvja-Xz+pc3bCwPi6f7U-5iA3=Z75h-w@mail.gmail.com>
	<5327DD6E.6030402@sugarcrm.com>
	<CAGa2bXZk1BhfM4Ze9_+XDpJshGeKi==sYTXJ=_76oCJr=r75SQ@mail.gmail.com>
	<CAPhkiZzE4PxOEzynQvCAquqtJ5Roajzb9GbHUb=a=rbxKTh+hA@mail.gmail.com>
	<CAGa2bXYP0dbB15q5z+_MfV4-XjCmWJTg11YxO-wC4hQCkq24BA@mail.gmail.com>
	<CAPhkiZz_dQLP-J2Z7iS+yrFWc8DmejSGRkVUEyfq9qsgCkmcuw@mail.gmail.com>
	<CAGa2bXYnvFz-MtH21+vg=3siAsK_uTndUNCptCkozW=OarGJ9A@mail.gmail.com>
Date: Wed, 19 Mar 2014 02:17:24 +0200
Message-ID: <CAPhkiZxXAKtnW5Tv6Bwi1nkrifRaovoo_kiU+A0x=k8=CqBf7A@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Revert/extend/postpone original RFC about
 read_only, lazy_write sessions
From: narf@devilix.net (Andrey Andreev)

Hi,

>> >> > How about making it a INI option? It makes session_start() option
>> >> > handling
>> >> > code
>> >> > a little simpler. It's not mandatory, though.
>> >>
>> >> +1 from me, if it is to be kept as an option.
>> >
>> >
>> > I'm about to modify patch to make it INI. No objections for this?
>>
>> Well, I said 'if' we keep it as an option at all. I'd rather update
>> the RFC to propose it as non-optional behavior since there are no
>> downsides from it, as I understand.
>
>
> How should we handle this?
> It was session_start() option e.g. session_start(['lazy_write'=>true]);
> We are proposing make it INI option.
>
> Since session_start() accepts all INI options, so it can work as
> session_start(['lazy_write'=>true]);
> with INI.
>
> Anyone?

I'll rephrase ... I'm proposing lazy_write at all times, no option.
Optional performance improvements don't make sense to me.

> Please refer to code for details.
>
> https://github.com/php/php-src/pull/628/

Wooow, that includes way more additions than those related to the
session-lock-ini RFC. Does it have to be all in one patch?

I'll comment further on github to avoid more spam here.

Cheers,
Andrey.