Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73281 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 19240 invoked from network); 19 Mar 2014 00:09:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Mar 2014 00:09:42 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.50 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.215.50 mail-la0-f50.google.com Received: from [209.85.215.50] ([209.85.215.50:51780] helo=mail-la0-f50.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A6/08-16983-440E8235 for ; Tue, 18 Mar 2014 19:09:41 -0500 Received: by mail-la0-f50.google.com with SMTP id y1so5339501lam.37 for ; Tue, 18 Mar 2014 17:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=betqJgo8NVW6Ne3m48TVx3vGzhR629evtNM9vAPiBbk=; b=Tozys6BXnY8nE9S2BG+BG46pEZzaqs1ffEyp5POXPxuLPMp4HhEAAQGtoanlS82ISK HpyvQOV7/34Vfe8ovSAp7xtuNTOIZeLblCkLfpEYL386jNG8LsPo2NQZ3pazgo2+aufG 2GsuG4u9I9rsy7YRBTq8YyUe8vAX5Mpp4kqSrzPgl09JUnyk5ZIUaxatG12hvTYhm8BX s+W7N/BDN5RO3hr3nzPwXMqMoFwBooNRTUpA3XmjoiGLs0E4twv6IFlSdpVTJPJj8phB e1N94P+l/0NOkvMYpyIuIDYaLcDHNbJ9V20pyNGT1wjuiqIc9Ic8+IDjPRuL6TBSIih4 uNwA== X-Received: by 10.152.209.70 with SMTP id mk6mr23483886lac.13.1395187778294; Tue, 18 Mar 2014 17:09:38 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.205.73 with HTTP; Tue, 18 Mar 2014 17:08:58 -0700 (PDT) In-Reply-To: <5327F947.5020308@sugarcrm.com> References: <53277BE2.8020203@sugarcrm.com> <5327F947.5020308@sugarcrm.com> Date: Wed, 19 Mar 2014 09:08:58 +0900 X-Google-Sender-Auth: 0doMp1KyxGgtQGIdkQygJYHRrx8 Message-ID: To: Stas Malyshev Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=001a11380246eb9ca304f4ea7781 Subject: Re: [PHP-DEV] Re: Session: deprecating create_sid() method and add createSid()? From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a11380246eb9ca304f4ea7781 Content-Type: text/plain; charset=UTF-8 Hi Stas, On Tue, Mar 18, 2014 at 4:44 PM, Stas Malyshev wrote: > > What is your opinion? > > My opinion it would be the best if we could support both and deprecate > create_sid in 5.6, but if it's hard to do cleanly, then leave it alone. > I've included createSid() definition in https://github.com/php/php-src/pull/628/ If create_sid() is defined, it's used. If both create_sid() and createSid() is defined, createSid() is used. SessionHandler does not use new SessionUpdateTimestampHandlerInterface, so user may choose what they would do about create_sid() and createSid(). Current session module's object handling is some what legacy, so such thing can be done. I think this is the best way. We can keep compatibility and have standard confirming createSid() name. Since it keeps compatibility with 5.5, we may leave 5.5 alone. If you would like, I can add similar change to 5.5. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a11380246eb9ca304f4ea7781--