Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73266
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.213.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZk1BhfM4Ze9_+XDpJshGeKi==sYTXJ=_76oCJr=r75SQ@mail.gmail.com>
References: <CAPhkiZw5xWRkc=ofh-nB5ZkjfThZFkH_+pK5RZaQFLKhno7u7A@mail.gmail.com>
	<CAGa2bXZiBuw_L_ehvTZb5_UUedtbS0n4GXYUjtKix0S9DX_8KQ@mail.gmail.com>
	<5324FE40.1070704@sugarcrm.com>
	<CAPhkiZy1oG_WHijMknB34dyo0aZRDU89EBafpaEGqGM32DCK0A@mail.gmail.com>
	<532603A0.8060802@sugarcrm.com>
	<CAPhkiZxdrxiKT3cTW9ra=0aFDKKP3-OpjmGdxqzHxu8YEUK2ww@mail.gmail.com>
	<CAGa2bXbH8WFp=8C-ON-1aAHLiyTsemVKMH+dGnqBSJAw5zw-GA@mail.gmail.com>
	<CAPhkiZx52CiKkk385itjEtg99ox3PHzXga9ZWDPbWiB2wRyH4g@mail.gmail.com>
	<CAGa2bXZGun=khdMZHzYoERap7qj7bQDPEfQzx2jJ2MwPs7-p_g@mail.gmail.com>
	<CAPhkiZzmzTqPR4KynBCWijvHa=TGKzTni7JdfuuKdy_i=sBeQg@mail.gmail.com>
	<CAGa2bXb6k8NYyYheCM6dvFWj-jA2GLP7ZiusTgZK-YgkNkeHhQ@mail.gmail.com>
	<CAPhkiZz-_PxvfsCiMDm8Hf9YzVNV+Ch1zpqDut19uV1w1WCWoA@mail.gmail.com>
	<CAGa2bXb45BizZ8g8zzdneV_27R7zgiX34xoZm+f8YyNQrZxdTQ@mail.gmail.com>
	<CAPhkiZxi0UxrrUMRNUFDmkzs2pX6y81PPabzLjLF-ChboaB8jg@mail.gmail.com>
	<CAGa2bXYajPoD6D34nPXvja-Xz+pc3bCwPi6f7U-5iA3=Z75h-w@mail.gmail.com>
	<5327DD6E.6030402@sugarcrm.com>
	<CAGa2bXZk1BhfM4Ze9_+XDpJshGeKi==sYTXJ=_76oCJr=r75SQ@mail.gmail.com>
Date: Tue, 18 Mar 2014 12:58:44 +0200
Message-ID: <CAPhkiZzE4PxOEzynQvCAquqtJ5Roajzb9GbHUb=a=rbxKTh+hA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Stas Malyshev <smalyshev@sugarcrm.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Revert/extend/postpone original RFC about
 read_only, lazy_write sessions
From: narf@devilix.net (Andrey Andreev)

Hi,


>> I think defaults should not change in minor version, unless there's a
>> very good reason for it, and here it's not a very good reason. Session

I don't think 5.6 is looked at as a minor version. Features have been
added, changed, deprecated and removed in previous 5.x releases.

>> module is very sensitive, and doing changes in it should be very
>> conservative to not break people's workflows. While new behavior serves
>> an important use case, it may not be everybody's use case, especially
>> with all handlers. Thus, I would rather have it an option - exactly as
>> voted. When we move into PHP 6, where certain major changes are
>> expected, we can change the defaults. But I think introducing such
>> change in a minor version is unnecessary risk.
>> And also it subverts RFC process as it's not what the vote was for, and
>> it's a substantial change - default behavior change (means, everybody
>> affected) instead of option (means, only people using the option affected

Exacly why I wrote an RFC, except Yasuo already explained that current
workflows (speaking of userland handlers) are not affected and BC is
maintaned.

> No problem.
>
> How about making it a INI option? It makes session_start() option handling
> code
> a little simpler. It's not mandatory, though.

+1 from me, if it is to be kept as an option.

> I found issue with object based user save handler. Unlike procedural user
> save handlers,
> object based user save handler uses previously used save handler as it's
> base class (some what)

Isn't that the whole point of it, that you can overload only specific
parts of the default one?

> I think we are better to have another SessionHandler object that support new
> APIs.
> We can handle create_sid() method rename with new object also. We may keep
> current implementation undocumented and may document it new one
> (createSid()) only.
> I will name it "SessionUpdateTimestampHandler". If anyone has suggestions,
> I would appreciate it.

I object, although it should've been called SessionFilesHandler in the
first place, that way we could also have SessionMemcacheHandler,
SessionWhateverHandler - way nicer than it currently is, but again -
not the point of this discussion.

Cheers,
Andrey.