Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73260 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 18413 invoked from network); 18 Mar 2014 07:44:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Mar 2014 07:44:12 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 108.166.43.107 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 108.166.43.107 smtp107.ord1c.emailsrvr.com Linux 2.6 Received: from [108.166.43.107] ([108.166.43.107:52035] helo=smtp107.ord1c.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1A/3A-17561-A49F7235 for ; Tue, 18 Mar 2014 02:44:11 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp6.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id 1E38A98CC8; Tue, 18 Mar 2014 03:44:08 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp6.relay.ord1c.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id C235498C73; Tue, 18 Mar 2014 03:44:07 -0400 (EDT) Message-ID: <5327F947.5020308@sugarcrm.com> Date: Tue, 18 Mar 2014 00:44:07 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Yasuo Ohgaki CC: "internals@lists.php.net" References: <53277BE2.8020203@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Session: deprecating create_sid() method and add createSid()? From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > If user uses undocumented interface (SessionIdInterface) they would have to > implement both createSid() and create_sid(). Alternatively, we may introduce > temporary interface for create_sid(). Or keep it undocumented and rename it > in 5.6 only. Doing to all this length for what? To rename a function? Looks hardly worth it. > Fortunately, current manual > http://jp2.php.net/manual/en/function.session-set-save-handler.php > is incomplete. It does not mention create_sid() and it's interface. It > does not > use interface for detailed version of example, too. It doesn't matter - it's there for 10 releases, so it's part of the API. > What is your opinion? My opinion it would be the best if we could support both and deprecate create_sid in 5.6, but if it's hard to do cleanly, then leave it alone. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227