Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73257 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 12010 invoked from network); 18 Mar 2014 06:13:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Mar 2014 06:13:00 -0000 Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.176 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.216.176 mail-qc0-f176.google.com Received: from [209.85.216.176] ([209.85.216.176:64443] helo=mail-qc0-f176.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 62/09-17561-AE3E7235 for ; Tue, 18 Mar 2014 01:12:59 -0500 Received: by mail-qc0-f176.google.com with SMTP id m20so7164523qcx.7 for ; Mon, 17 Mar 2014 23:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=WhaKHHMAz/rDp5T5qB39/6TE8akFhh1OI8JVhERLoFg=; b=ZWs48OMPsQ61YGaJvlwq5o5h0lcFF+A+w2oIMOeOy/KeZjscQR/wOF9g7ZqplTj8Sw 8FmEz0/hPpry51YrdcgueOU/qcoWRR81crAx11ZHpH1nGP5/Ay9zperi98TRZ6/81Kda B6YRyKUyRJuap4J/H4HEifpRXr1a2scGOOSl8bjTQkRJc0iCpg7BRsOH3mxH7S+ycI3r yqHVQ4/vvanYWah+eGGGb+PfuOQ/YaroHlXD5FIIDrci69GgoVg4y/5XrowDXUtRa0Z4 OhkXjz4Acctxxp46C2WgFqcMFPAd4ov0b+UyDWgA1/zVTaXN4A2Zn1m+Pksbi2poLC3r CaeA== MIME-Version: 1.0 X-Received: by 10.224.137.5 with SMTP id u5mr33779071qat.12.1395123176042; Mon, 17 Mar 2014 23:12:56 -0700 (PDT) Received: by 10.140.17.34 with HTTP; Mon, 17 Mar 2014 23:12:55 -0700 (PDT) Received: by 10.140.17.34 with HTTP; Mon, 17 Mar 2014 23:12:55 -0700 (PDT) In-Reply-To: References: Date: Tue, 18 Mar 2014 07:12:55 +0100 Message-ID: To: Nikita Popov Cc: PHP internals Content-Type: multipart/alternative; boundary=001a11c2860453757604f4db6d26 Subject: Re: [PHP-DEV] Re: Add support for PCRE marks From: tyra3l@gmail.com (Ferenc Kovacs) --001a11c2860453757604f4db6d26 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2014.03.17. 22:52, "Nikita Popov" ezt =C3=ADrta: > > On Fri, Feb 28, 2014 at 9:37 PM, Nikita Popov wrote: > > > Hi internals! > > > > I wrote a patch to expose PCRE mark information in PHP, see > > https://github.com/php/php-src/pull/609/files. The last passed *MARK will > > be added to the $matches array under key "MARK". If you don't use marks > > everything stays exactly the same. > > > > Does anyone have a problem with exposing it in this way? > > > > In this context, would there be a problem with increasing the minimum > > required PCRE version (for builds against an external library) from 6.6 to > > 8.10 (the current, bundled version is 8.34)? That would avoid adding > > #ifdefs for this code. Is there some particular reason for 6.6 here? > > > > I merged this with ifdefs for now (ping me if you have build issues, I > didn't actually test this). > > It would still be nice to increase the minimum version number for 5.6, > because allowing prehistoric PCRE versions in a new release makes zero > sense. I recommend at least 8.10 because it both supports marks and - mor= e > relevantly to most users - supports UCP mode, which PHP uses by default (if > available). UCP mode can significantly change the behavior of PCRE with the > /u modifier, as such guaranteeing a minimum version of 8.10 will also > guarantee a somewhat consistent /u behavior. > > Nikita +1 for bumping the minimum pcre version requirement. Could we check what major linux distros ship currently just to be safe? --001a11c2860453757604f4db6d26--