Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73253
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.52 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <53277BE2.8020203@sugarcrm.com>
References: <CAGa2bXb09KO-ydd-vf3rJMR=pjQZ=1kG0Qq+snLoKPEL+Fp6XQ@mail.gmail.com>
 <CAGa2bXZGK06+aqe3HOEo9BC2R71a8HaBCqjBn=g_RbEK6u-Uqw@mail.gmail.com> <53277BE2.8020203@sugarcrm.com>
Date: Tue, 18 Mar 2014 09:24:09 +0900
Message-ID: <CAGa2bXadowN=wdxizXXLgOEB5pZArdAOEs653U-=5AkAcg6_4Q@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1134947467c7b804f4d69046
Subject: Re: [PHP-DEV] Re: Session: deprecating create_sid() method and add createSid()?
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a1134947467c7b804f4d69046
Content-Type: text/plain; charset=UTF-8

Hi Stas,

On Tue, Mar 18, 2014 at 7:49 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> > Since create_sid() method is added in 5.5.1 and it's not documented yet.
> > I would like to propose renaming it to createSid() for both 5.5 and 5.6.
>
> Renaming is a BC break and it's there for 10 releases already, so it'd
> be a no go. You can add an alias of createSid, but then you'd have to be
> very careful so that overriding both create_sid and createSid would work
> the same (including when parent:: is involved). If it's hard to do
> cleanly then I'd rather prefer keeping create_sid.


Since session module's object save handler support is legacy, session
module can modify how methods are used/defined when user is not using
interface.
i.e. session module is not using 'interface' normal way.

Procedural session_create_sid() API is there very long time, but
object's create_sid() method was introduced since 5.5.1. I would not
change procedural session_create_sid() name as it is proper name for it.

If user uses undocumented interface (SessionIdInterface) they would have to
implement both createSid() and create_sid(). Alternatively, we may introduce
temporary interface for create_sid(). Or keep it undocumented and rename it
in 5.6 only.

Fortunately, current manual
http://jp2.php.net/manual/en/function.session-set-save-handler.php
is incomplete. It does not mention create_sid() and it's interface. It does
not
use interface for detailed version of example, too.

I'll update the manual when everything is sorted out.

For now, we should decide
 - Keep create_sid() method in 5.5 or not
 - Add createSid() method in 5.5 or not
 - For interface, we have many options. Add new interface for createSid(),
simply adding createSid() to SessionIdInterface, etc.

I think session_sid() should be renamed to sessionSid() for 5.6, but I don't
care much about 5.5. I'll implement it in the way everyone satisfies.

What is your opinion?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a1134947467c7b804f4d69046--