Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73245
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.50 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAPhkiZxtGCyrEOgqsSiJ6GPVGFu_u4uF9MXiYam4b3ngLf2ZxQ@mail.gmail.com>
References: <CAGa2bXb09KO-ydd-vf3rJMR=pjQZ=1kG0Qq+snLoKPEL+Fp6XQ@mail.gmail.com>
 <CAGa2bXZGK06+aqe3HOEo9BC2R71a8HaBCqjBn=g_RbEK6u-Uqw@mail.gmail.com> <CAPhkiZxtGCyrEOgqsSiJ6GPVGFu_u4uF9MXiYam4b3ngLf2ZxQ@mail.gmail.com>
Date: Tue, 18 Mar 2014 06:55:31 +0900
Message-ID: <CAGa2bXaB4EFm3JJTy0YxjZfA3g7dU3y+Bmfn_KAy+OfkpzWXMQ@mail.gmail.com>
To: Andrey Andreev <narf@devilix.net>, Leigh <leight@gmail.com>, 
	Stas Malyshev <smalyshev@sugarcrm.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1133e308db3cdc04f4d47c4b
Subject: Re: [PHP-DEV] Re: Session: deprecating create_sid() method and add createSid()?
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a1133e308db3cdc04f4d47c4b
Content-Type: text/plain; charset=UTF-8

Hi Stas,

On Tue, Mar 18, 2014 at 6:44 AM, Andrey Andreev <narf@devilix.net> wrote:

> On Mon, Mar 17, 2014 at 11:35 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> > Hi all,
> >
> > Since create_sid() method is added in 5.5.1 and it's not documented yet.
> > I would like to propose renaming it to createSid() for both 5.5 and 5.6.
> >
> >  Any comments?
>
> I also thought about this, but I'm kind of split ... some users
> (besides Leigh here) might've found it and be currently using it
> regardless. And now that I know create_sid() exists, I'll surely use
> it too in pre-5.6 apps. I guess it won't hurt to still look for it if
> createSid() (or maybe even createId(), it's in the context of sessions
> after all) doesn't exist.


What do you think about this?

It could be made both create_sid() and createSid() available in 5.5 and
remove create_sid() in 5.6.

Simple renaming is cleaner and may be acceptable, since it's undocumented
and relatively new feature. I'm not sure if it is good to have more complex
code
for undocumented feature.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a1133e308db3cdc04f4d47c4b--