Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73244
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c8VvR0QW12zdKpWxodGSaZRp+7Mp7vNGRjFM+V+eFZR0w@mail.gmail.com>
References: <CAF+90c8VvR0QW12zdKpWxodGSaZRp+7Mp7vNGRjFM+V+eFZR0w@mail.gmail.com>
Date: Mon, 17 Mar 2014 22:51:58 +0100
Message-ID: <CAF+90c-JEfYuDiwcqftuFp71WvBQENPhmVHZehM-gzmkfDm-PQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d04479f93c67ab504f4d46da3
Subject: Re: Add support for PCRE marks
From: nikita.ppv@gmail.com (Nikita Popov)

--f46d04479f93c67ab504f4d46da3
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Feb 28, 2014 at 9:37 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals!
>
> I wrote a patch to expose PCRE mark information in PHP, see
> https://github.com/php/php-src/pull/609/files. The last passed *MARK will
> be added to the $matches array under key "MARK". If you don't use marks
> everything stays exactly the same.
>
> Does anyone have a problem with exposing it in this way?
>
> In this context, would there be a problem with increasing the minimum
> required PCRE version (for builds against an external library) from 6.6 to
> 8.10 (the current, bundled version is 8.34)? That would avoid adding
> #ifdefs for this code. Is there some particular reason for 6.6 here?
>

I merged this with ifdefs for now (ping me if you have build issues, I
didn't actually test this).

It would still be nice to increase the minimum version number for 5.6,
because allowing prehistoric PCRE versions in a new release makes zero
sense. I recommend at least 8.10 because it both supports marks and - more
relevantly to most users - supports UCP mode, which PHP uses by default (if
available). UCP mode can significantly change the behavior of PCRE with the
/u modifier, as such guaranteeing a minimum version of 8.10 will also
guarantee a somewhat consistent /u behavior.

Nikita

--f46d04479f93c67ab504f4d46da3--