Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73235
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.172 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAPwsocHht=UAApnX_=-6MEe0_qowLvEjGhBPAMT1CWgsQOzSfw@mail.gmail.com>
References: <CAPhkiZzAxQnQpWOh7xhAM4h3r7xCYjD_P3d9mWmDX4Sr0Qc9Ng@mail.gmail.com>
 <CAPwsocHht=UAApnX_=-6MEe0_qowLvEjGhBPAMT1CWgsQOzSfw@mail.gmail.com>
Date: Tue, 18 Mar 2014 06:16:29 +0900
Message-ID: <CAGa2bXZHrv54Tqvsoov-v-7t8um8AR4Rn7kGOBdcvPZqaft05Q@mail.gmail.com>
To: Leigh <leight@gmail.com>
Cc: Andrey Andreev <narf@devilix.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b3441c43d2bf104f4d3f1c1
Subject: Re: [PHP-DEV] Session: deprecating create_sid() method and add createSid()?
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--047d7b3441c43d2bf104f4d3f1c1
Content-Type: text/plain; charset=UTF-8

Hi Leligh,

On Mon, Mar 17, 2014 at 10:22 PM, Leigh <leight@gmail.com> wrote:

> On 17 March 2014 10:23, Andrey Andreev <narf@devilix.net> wrote:
>
> > Hi Yasuo,
> >
> > There's no SessionHandler::create_sid() or
> > SessionHandlerInterface::create_sid() documented (see your own link to
> > the docs) ... since when is this available?
> >
> > I'm not sure if exposing it is a good idea anyway, why is it necessary?
> >
> >
>
> It was added in 5.5.1 - The PR was made 2 years ago by myself:
> https://github.com/php/php-src/pull/109
>
> It's not documented because I'm lazy, (it's one of those TODO items that
> has become permanent), but I personally use it. The underlying method on
> the session interface has been there for a long time (10 years might even
> be accurate), but for some unknown reason, it was not exposed to userland
> when all of the other methods were.
>
> It is necessary for custom session handler classes because without it calls
> to session_regenerate_id() do not inform the session handler about the
> change of session id. The presence of this method allows you to capture
> session id regeneration, and update files, databases, etc. as necessary,
> and also allows you to fully customise the actual session id token that is
> used. Custom prefixes, body content, encoding charset, etc.


Thank you for clarification. I didn't realize when it was implemented.
Documentation at that time would be nice w/o session_create_id().
If it is added 5.5.1, it would be safer to rename.

I think procedural session_create_sid() interface was added long time ago,
but
it's not important. As it is deprecated by documentation and I wouldn't
change
the name.

User defined save handler documentation should be improved. I think
many users are returning invalid value for read() especially.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--047d7b3441c43d2bf104f4d3f1c1--