Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73220
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.49 as permitted sender)
MIME-Version: 1.0
Sender: are.you.winning@gmail.com
In-Reply-To: <CAPhkiZxUuX3mrfdj6D6JnrYqU59uoQkcfCsB_Pc0T1DYpKgX4w@mail.gmail.com>
References: <CAPhkiZzAxQnQpWOh7xhAM4h3r7xCYjD_P3d9mWmDX4Sr0Qc9Ng@mail.gmail.com>
	<CAPwsocHht=UAApnX_=-6MEe0_qowLvEjGhBPAMT1CWgsQOzSfw@mail.gmail.com>
	<CAPhkiZxUuX3mrfdj6D6JnrYqU59uoQkcfCsB_Pc0T1DYpKgX4w@mail.gmail.com>
Date: Mon, 17 Mar 2014 14:11:45 +0000
Message-ID: <CAGAGxbbdU5BFqLfn82dJO4+BYh04U=Q-CFKfRwXuQc3HhBS1jw@mail.gmail.com>
To: Andrey Andreev <narf@devilix.net>
Cc: Leigh <leight@gmail.com>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Session: deprecating create_sid() method and add createSid()?
From: daverandom@php.net (Chris Wright)

On 17 March 2014 13:57, Andrey Andreev <narf@devilix.net> wrote:
> HI,
>
> On Mon, Mar 17, 2014 at 3:22 PM, Leigh <leight@gmail.com> wrote:
>>
>> On 17 March 2014 10:23, Andrey Andreev <narf@devilix.net> wrote:
>>>
>>> Hi Yasuo,
>>>
>>> There's no SessionHandler::create_sid() or
>>> SessionHandlerInterface::create_sid() documented (see your own link to
>>> the docs) ... since when is this available?
>>>
>>> I'm not sure if exposing it is a good idea anyway, why is it necessary?
>>>
>>
>>
>> It was added in 5.5.1 - The PR was made 2 years ago by myself:
>> https://github.com/php/php-src/pull/109
>>
>> It's not documented because I'm lazy, (it's one of those TODO items that has
>> become permanent), but I personally use it. The underlying method on the
>> session interface has been there for a long time (10 years might even be
>> accurate), but for some unknown reason, it was not exposed to userland when
>> all of the other methods were.
>>
>> It is necessary for custom session handler classes because without it calls
>> to session_regenerate_id() do not inform the session handler about the
>> change of session id. The presence of this method allows you to capture
>> session id regeneration, and update files, databases, etc. as necessary, and
>> also allows you to fully customise the actual session id token that is used.
>> Custom prefixes, body content, encoding charset, etc.
>
> I see ... that (and the PR discussion) answers all of my questions,
> thanks. Btw, I could take the docs out of your TODO list, as long as I
> can figure out of all repos, which one do I need to fork so I can push
> documentation additions ... the web interface sucks.

Docs are still in SVN, by far the easiest way to do it is via the OE
(http://edit.php.net/).

If you want to check the English docs out via SVN, use
https://svn.php.net/repository/phpdoc/modules/doc-en

> With that said, +1 for changing it to SessionHandler::createSid().
>
> Cheers,
> Andrey.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>