Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73183 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 84775 invoked from network); 16 Mar 2014 00:46:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Mar 2014 00:46:42 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.47 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.215.47 mail-la0-f47.google.com Received: from [209.85.215.47] ([209.85.215.47:35213] helo=mail-la0-f47.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EE/10-16948-074F4235 for ; Sat, 15 Mar 2014 19:46:41 -0500 Received: by mail-la0-f47.google.com with SMTP id y1so2770088lam.34 for ; Sat, 15 Mar 2014 17:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=yyxuZfooRY/ljJUh+vqwOKs27iv88NZPozvFQEWgCSk=; b=zo3Y1qMPnciuC5mQymZnaVMsL6bhL57J3NfRlkxgXwNFcy1e5J4BHy4YeeD/nfEBfK D8ESV6rUnta+boaiQXSc+MPJTHbLskckOvAUCpacmlrS/eONtFQTbEqSL7BTzlrNRHYp NH1H3s/QYkEkAexpLEIJs+02Rjodkw3FuiD4L5H8kn/THH9undpc2MkxFA53Er32BABq eQHo+iUdYHTnpv12OcF6gm4KuiOTCdsz4Mqwre1HZnvi6IhWlp17bMds9H3tI6SRuG+I g8gjYwYKauD5wbEQHJA0bR+Q5V8/NS9MgZdE2MzRWoKoE7j6HFDr9/C6XzpCC5s/WnDN r2Bg== X-Received: by 10.112.13.101 with SMTP id g5mr50065lbc.39.1394930797532; Sat, 15 Mar 2014 17:46:37 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.205.73 with HTTP; Sat, 15 Mar 2014 17:45:57 -0700 (PDT) In-Reply-To: References: Date: Sun, 16 Mar 2014 09:45:57 +0900 X-Google-Sender-Auth: ICensqQypGzZKu-rAWjU0B7eoqs Message-ID: To: Andrey Andreev Cc: Patrick Schaaf , internals , Pierre Joye Content-Type: multipart/alternative; boundary=001a11c3a6fcac5bf104f4aea2ef Subject: Re: [PHP-DEV] Re: Revert session_serializer_name(), session_gc() From: yohgaki@ohgaki.net (Yasuo Ohgaki) --001a11c3a6fcac5bf104f4aea2ef Content-Type: text/plain; charset=UTF-8 Hi Andrey, You need to argue why missing APIs that are added aren't needed. Just because they were missing years will not make them unneeded. For example, there are few new function requests for mbstring. Just adding missing APIs to _NEW_ release does not require RFC, simply making thing more efficient and faster does not require RFC, making small internal BC does not require RFC, does it? You are asking to make RFC always. (I didn't say discussion isn't needed) Anyone can make pull requests now. I even send PR if there needs to have some agreement. Anyone can comment committed patch. On Sun, Mar 16, 2014 at 3:33 AM, Andrey Andreev wrote: > >> > "write short circuit" omits "write" when $_SESSION hasn't change. > There > >> > is > >> > no point calling write API and writing to storage for the same data. > >> > >> "write short circuit" as I understand it, is an exact copy of the > >> 'lazy_write' option. This will be addressed in the previously > >> mentioned RFC that I'll post later today. > > > > > > No. It's not. > > > > "lazy_write" does not lock session data while "write short circuit" does. > > In other words, "lazy_write" changes session behavior, but "write short > > circuit" does not. > > i.e. With locked session data, "write short circuit" would not change how > > session manager works. > > I can't stress enough how confusing and potentially unsafe that is It does not make difference since many users use session_commit() to get more concurrency already. Simple documentation would be enough to understand what it does. There are freedom to shoot their own foot by themselves in any languages. We have better performance/more complex operations/convenience in return. Rather than discussing missing APIs are needed or not, I would like to discuss session_regenerate_id() issue. This is the design issue of session manager. IMO. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --001a11c3a6fcac5bf104f4aea2ef--