Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73175
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.160.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYBqD_5UW6fBahnR0ad7BQsdUnTiiQVBtcXefOH0BHv_w@mail.gmail.com>
References: <CAPhkiZx=0Vr5p=7VZJD4PeD0ub-khSVMw3G03QhO8CC4xxm11A@mail.gmail.com>
	<CAGa2bXZTU5HzM4oXyiu0PnS=W2Oz1uLP_BnyWBUXyYUTO0tMYg@mail.gmail.com>
	<CAPhkiZz_d_wFPgwwYXJD-A+tz0Uf9KQ6uXNi1HhZGWFF1=W91A@mail.gmail.com>
	<CAGa2bXY86ri7b=rquo8Vbbh5ZoHOkwGBRoPWPup-SVPMu0WEgg@mail.gmail.com>
	<CAPhkiZyEqcx+UTPzpyYjz9pxWJnCNDO9pUMQNxvTpnrxmez9nw@mail.gmail.com>
	<CAGa2bXb5rLU26NDDHkWDw-FYf=vh2J=LAGFrqU3A3JJpOTY_dA@mail.gmail.com>
	<CAPhkiZyyXuqqybs+q8rnp_eJZDU0De2wMqwfv5mWiihr9GsueQ@mail.gmail.com>
	<CAGa2bXboo3CGOP9x+fW0Q98aniBcXejkGSJv5=qygL9ia67FbA@mail.gmail.com>
	<CAPhkiZzaTCE6sR=Rt=4VBmVOCo+uSQMREpf-fg6hWBrbCW+RXQ@mail.gmail.com>
	<CAGa2bXYWVoX_05BdS0M-V5G+B=4v-W-DPbWT8-vPrtd=gJtcCg@mail.gmail.com>
	<CAJ26g5TfiwjECNH_GbU6OCwCJdCCRJxKLUBL6wtw89XNo8P2eg@mail.gmail.com>
	<CAGa2bXbeucsEK2X1_wvtY_zMXs6guQAWxEMFhpjhyyOopq3sog@mail.gmail.com>
	<CAEZPtU6J01hP2+xjRUhTY9+rq9dTZyPOv9Mes_Xt0jiogsCE9w@mail.gmail.com>
	<CAPhkiZx3iUo=4cJYkB7KPcD8TMs79kvLBrnBdGUZ4YqTq-+h-Q@mail.gmail.com>
	<CAPhkiZx_ztbVXFm10_4MSQyqkBDYVqBiCmNBdF4k7N9fev5uLQ@mail.gmail.com>
	<CAGa2bXafxzFTMRfn16JNDgWm2tPQeuYE8cdqg9BbRsKSy3S1QA@mail.gmail.com>
	<CAPhkiZxO44Cj7h_NP-5_ZtixLuFoWJrtdPsRabJHP5yTOrCf5g@mail.gmail.com>
	<CAGa2bXbtMQ2cQoe-X1S=Ab05iS7yph9x6Kw5DjfsHdrNEjGF4w@mail.gmail.com>
	<CAPhkiZxdUFjWrRm7SAtagLmtZXPDbsXp9Cv13u2ChKLsuuxtgA@mail.gmail.com>
	<CAGa2bXZ458+diX3FFh3tw_W28y9MZpipmWrPfQ8obo-Z3n9S8w@mail.gmail.com>
	<CAPhkiZz8aH0H9-rJQxkQAzC_LgAPgy4c75uS74xiDZ_30H7DAA@mail.gmail.com>
	<CAJ26g5STp=DeJ7u9k2Z97HG2+qG+knXOJ_7L1srtU03Ca3u_1Q@mail.gmail.com>
	<CAPhkiZxRdPOJyWtktvcwN-=Bp2M=fBE9i8jG4WgTnZYysdvibg@mail.gmail.com>
	<CAGa2bXbJhBu9htc1PY0Rr-_GW0Zp6=z6=Y=jqpee3O5KEsF1wg@mail.gmail.com>
	<CAPhkiZy69Z=15TNGHrnVmoJ8C+9CtAPf=dTaOkphqOb-V0n+4A@mail.gmail.com>
	<CAGa2bXYCdAwU-LUjHk7gKcQ5fnoqm_q3sSn=uG-591=9sCqYqA@mail.gmail.com>
	<CAGa2bXYBqD_5UW6fBahnR0ad7BQsdUnTiiQVBtcXefOH0BHv_w@mail.gmail.com>
Date: Sat, 15 Mar 2014 07:10:07 +0200
Message-ID: <CAPhkiZyG+i8j6mCa-K7PkwaxLBkmBuLZ9UNqznfewzUj4yRtOg@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Patrick Schaaf <bof@bof.de>, internals <internals@lists.php.net>, 
	Pierre Joye <pierre.php@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Re: Revert session_serializer_name(), session_gc()
From: narf@devilix.net (Andrey Andreev)

Hi,

On Sat, Mar 15, 2014 at 6:36 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi all,
>
> On Sat, Mar 15, 2014 at 1:15 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>>>
>>>
>>> Now back to the main topic:
>>>
>>> Please exclude session_serializer_name(), session_gc(),
>>> session_reset(), session_abort() and the "session write short-circuit"
>>> from the 5.6 branch.
>>
>>
>> I removed session_serializer_name() and session_gc()
>> (Although session_gc() is mandatory API, IMO)
>> I like the idea removing INI modifying function in the future release.
>>
>> I don't understand reason why you insist removal of session_reset()
>> and session_abort(). They are just missing API for session module,
>> like session_gc().
>>
>> There should be API (i.e. function/method or parameters) for distinct
>> operations that user may use.
>>
>> I may agree if you could provide the reason why there should not be
>> these APIs.

session_abort(), session_reset() are just two functions that somebody
asked about in 2002 via bugs.php.net and nobody responded (11 years
without a single comment) right up until you just assumed it's a good
idea and commited it. If it was "missing API", surely at least 1 user
per year would've requested it. ;)

I understand that you see them as small, trivial additions, but being
a part of sessions automatically makes them very important and as
such, they should be evaluated collectively, not by a single person.

> I thought it might be better to explain what new functions do.
>
> session_gc() executes GC without tweaking INIs.
> session_abort() aborts session without writing $_SESSION. There is no way
> achieve w/o it.
> session_reset() re-reads session and re-initializes $_SESSION. There is no
> way achieve w/o it. (It could be done with session_abort(), though)
> "write short circuit" omits "write" when $_SESSION hasn't change. There is
> no point calling write API and writing to storage for the same data.

"write short circuit" as I understand it, is an exact copy of the
'lazy_write' option. This will be addressed in the previously
mentioned RFC that I'll post later today.

Cheers,
Andrey.