Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73155
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.171 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAPhkiZz8aH0H9-rJQxkQAzC_LgAPgy4c75uS74xiDZ_30H7DAA@mail.gmail.com>
References: <CAPhkiZx=0Vr5p=7VZJD4PeD0ub-khSVMw3G03QhO8CC4xxm11A@mail.gmail.com>
 <CAGa2bXZTU5HzM4oXyiu0PnS=W2Oz1uLP_BnyWBUXyYUTO0tMYg@mail.gmail.com>
 <CAPhkiZz_d_wFPgwwYXJD-A+tz0Uf9KQ6uXNi1HhZGWFF1=W91A@mail.gmail.com>
 <CAGa2bXY86ri7b=rquo8Vbbh5ZoHOkwGBRoPWPup-SVPMu0WEgg@mail.gmail.com>
 <CAPhkiZyEqcx+UTPzpyYjz9pxWJnCNDO9pUMQNxvTpnrxmez9nw@mail.gmail.com>
 <CAGa2bXb5rLU26NDDHkWDw-FYf=vh2J=LAGFrqU3A3JJpOTY_dA@mail.gmail.com>
 <CAPhkiZyyXuqqybs+q8rnp_eJZDU0De2wMqwfv5mWiihr9GsueQ@mail.gmail.com>
 <CAGa2bXboo3CGOP9x+fW0Q98aniBcXejkGSJv5=qygL9ia67FbA@mail.gmail.com>
 <CAPhkiZzaTCE6sR=Rt=4VBmVOCo+uSQMREpf-fg6hWBrbCW+RXQ@mail.gmail.com>
 <CAGa2bXYWVoX_05BdS0M-V5G+B=4v-W-DPbWT8-vPrtd=gJtcCg@mail.gmail.com>
 <CAJ26g5TfiwjECNH_GbU6OCwCJdCCRJxKLUBL6wtw89XNo8P2eg@mail.gmail.com>
 <CAGa2bXbeucsEK2X1_wvtY_zMXs6guQAWxEMFhpjhyyOopq3sog@mail.gmail.com>
 <CAEZPtU6J01hP2+xjRUhTY9+rq9dTZyPOv9Mes_Xt0jiogsCE9w@mail.gmail.com>
 <CAPhkiZx3iUo=4cJYkB7KPcD8TMs79kvLBrnBdGUZ4YqTq-+h-Q@mail.gmail.com>
 <CAPhkiZx_ztbVXFm10_4MSQyqkBDYVqBiCmNBdF4k7N9fev5uLQ@mail.gmail.com>
 <CAGa2bXafxzFTMRfn16JNDgWm2tPQeuYE8cdqg9BbRsKSy3S1QA@mail.gmail.com>
 <CAPhkiZxO44Cj7h_NP-5_ZtixLuFoWJrtdPsRabJHP5yTOrCf5g@mail.gmail.com>
 <CAGa2bXbtMQ2cQoe-X1S=Ab05iS7yph9x6Kw5DjfsHdrNEjGF4w@mail.gmail.com>
 <CAPhkiZxdUFjWrRm7SAtagLmtZXPDbsXp9Cv13u2ChKLsuuxtgA@mail.gmail.com>
 <CAGa2bXZ458+diX3FFh3tw_W28y9MZpipmWrPfQ8obo-Z3n9S8w@mail.gmail.com> <CAPhkiZz8aH0H9-rJQxkQAzC_LgAPgy4c75uS74xiDZ_30H7DAA@mail.gmail.com>
Date: Fri, 14 Mar 2014 19:30:42 +0900
Message-ID: <CAGa2bXa6iatNpGTaQWkqJv7A__UobWdSkeYeCTCW72WGcqfvGw@mail.gmail.com>
To: Andrey Andreev <narf@devilix.net>
Cc: Pierre Joye <pierre.php@gmail.com>, Patrick Schaaf <bof@bof.de>, 
	internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11347e9e34adf204f48e92f4
Subject: Re: [PHP-DEV] Re: Revert session_serializer_name(), session_gc()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11347e9e34adf204f48e92f4
Content-Type: text/plain; charset=UTF-8

Hi Andrey,

On Fri, Mar 14, 2014 at 7:07 PM, Andrey Andreev <narf@devilix.net> wrote:

> This is broken, consider the following (multiple tab/ajax/whatever
> concurrency) scenario:
>
> Request1: session_start(['read_only' => TRUE]);
> Request2: session_start(); unset($_SESSION['logged_in']); session_commit();
> Request1: still logged in
>
> ^ This screams "danger".
>

I think all of us know what it does.


>
> It's also, redundant ... do you really believe you'd get +1 votes for
> that feature if the voters were *really* aware that this would be just
> an alias for (sesson_start() && session_commit()) ?
>

It's not alias. It's much more efficient.


>  I don't think so. This is simply not what "read only" means which
> makes this whole thing very misleading and if people who were supposed
> to review the feature got confused by it, imagine what happens in
> userland.
>

I might not explain well enough in the RFC, but most of use understood it's
a faster version of session_start();session_commit().

Calling session_commit() right after session_start() is common optimization
technique. Making it more efficient worth it.

I think there is no point to write back to the session data while
programmer only needs to read the data. Since
session_start();session_commit(); is optimization technique, making it more
efficient makes sense.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.netsession_start();session_commit()

--001a11347e9e34adf204f48e92f4--