Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73106
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.160.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU6J01hP2+xjRUhTY9+rq9dTZyPOv9Mes_Xt0jiogsCE9w@mail.gmail.com>
References: <CAPhkiZx=0Vr5p=7VZJD4PeD0ub-khSVMw3G03QhO8CC4xxm11A@mail.gmail.com>
	<CAGa2bXZTU5HzM4oXyiu0PnS=W2Oz1uLP_BnyWBUXyYUTO0tMYg@mail.gmail.com>
	<CAPhkiZz_d_wFPgwwYXJD-A+tz0Uf9KQ6uXNi1HhZGWFF1=W91A@mail.gmail.com>
	<CAGa2bXY86ri7b=rquo8Vbbh5ZoHOkwGBRoPWPup-SVPMu0WEgg@mail.gmail.com>
	<CAPhkiZyEqcx+UTPzpyYjz9pxWJnCNDO9pUMQNxvTpnrxmez9nw@mail.gmail.com>
	<CAGa2bXb5rLU26NDDHkWDw-FYf=vh2J=LAGFrqU3A3JJpOTY_dA@mail.gmail.com>
	<CAPhkiZyyXuqqybs+q8rnp_eJZDU0De2wMqwfv5mWiihr9GsueQ@mail.gmail.com>
	<CAGa2bXboo3CGOP9x+fW0Q98aniBcXejkGSJv5=qygL9ia67FbA@mail.gmail.com>
	<CAPhkiZzaTCE6sR=Rt=4VBmVOCo+uSQMREpf-fg6hWBrbCW+RXQ@mail.gmail.com>
	<CAGa2bXYWVoX_05BdS0M-V5G+B=4v-W-DPbWT8-vPrtd=gJtcCg@mail.gmail.com>
	<CAJ26g5TfiwjECNH_GbU6OCwCJdCCRJxKLUBL6wtw89XNo8P2eg@mail.gmail.com>
	<CAGa2bXbeucsEK2X1_wvtY_zMXs6guQAWxEMFhpjhyyOopq3sog@mail.gmail.com>
	<CAEZPtU6J01hP2+xjRUhTY9+rq9dTZyPOv9Mes_Xt0jiogsCE9w@mail.gmail.com>
Date: Thu, 13 Mar 2014 12:36:35 +0200
Message-ID: <CAPhkiZx3iUo=4cJYkB7KPcD8TMs79kvLBrnBdGUZ4YqTq-+h-Q@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Yasuo Ohgaki <yohgaki@ohgaki.net>, Patrick Schaaf <bof@bof.de>, internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: Revert session_serializer_name(), session_gc()
From: narf@devilix.net (Andrey Andreev)

Hi,

> The _proper_ solution, would be to keep a timestamp stored with each sess=
ion. kind of a last-modified timestamp. (expiry does work off last modifica=
tion, right?). Anyhow, the trick is to check at session_start whether that =
timestamp plus whatever session.expire is set at, already is in the past - =
and when that happens, destroy the one session on storage and act as if it =
hadn't been found.

Such a timestamp already exists, you can't implement sessions without
one because there would be no way to know when a session have expired.
For the files handler, it's filemtime() (afaik) and the behavior that
you described is probably already in use (I see no reason not to).

However, that's not in the scope of GC.

> a GC is only needed to clean up sessions that are never requested again -=
 and for that I fully agree that a separate - e.g. cron driven - "GC now" j=
ob would be best (not affecting latency of running frontent requests too mu=
ch).

^ That is what a garbage collector is, indeed. :)

On Thu, Mar 13, 2014 at 11:22 AM, Pierre Joye <pierre.php@gmail.com> wrote:
> On Thu, Mar 13, 2014 at 8:45 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
>> It may be good idea to write a new save handler interface while keeping
>> older one.
>
>
> It would really helpful to target a later versions, maybe 6 and see
> what we can do while minimizing the impact in userlands (whether or
> not custom session handlers are implemented).
>
> But all the discussions and RFCs about basically the same needs have
> been very confusing.
>
> What do you think? Is it something you could consider?

I am deffinately a proponent of that. I already mentioned earlier that
I have some ideas ... this is one of them.

However, while Yasuo seems to always be keen on creating RFCs
immediately, I'd rather focus on the existing ones that are session
related:

https://wiki.php.net/rfc/secure-session-options-by-default
https://wiki.php.net/rfc/session_regenerate_id

5.6 is really close and this is important stuff that was supposed to
go in, but has not had updates recently and lagged behind.
Changes for future versions can wait a few days/weeks ...

Cheers,
Andrey.