Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73093 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94746 invoked from network); 13 Mar 2014 01:40:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Mar 2014 01:40:51 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.172 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.217.172 mail-lb0-f172.google.com Received: from [209.85.217.172] ([209.85.217.172:60276] helo=mail-lb0-f172.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1D/F1-17655-2AC01235 for ; Wed, 12 Mar 2014 20:40:50 -0500 Received: by mail-lb0-f172.google.com with SMTP id c11so219267lbj.17 for ; Wed, 12 Mar 2014 18:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=vferCBVK1j8Gf7AqULZnqtpLqMcecV0ZHHvWkMB2N3Q=; b=U6Wg47f/zZ9MkNVrqkPfttPtEmXNXjTS9fZifdzsiX34/kok0iF5JNBWGdhugEE7UO zuVs7a+H4Y0LDr5g11wPZMOn6rhnCtjoH4+1AUkLog+diFmw2ArrlRLVFQrHaDDx7eDN gET200lZypCt25lTRDF1kF+D11B2v0gVKPZyMgdOALDe3dNPXz8Y5mPhVLxKOJjjmOlO s+VWYM3ARfhMNasxf1fjSXT/ITqJPrFq+NxOgYtuDJSAgucm6E4l9FsAdSCjjwwZJEu+ EiL9fJdWmzPg1W4ZiIPR7moHABHPnn60Er6kUb5xzZLeAeBrSjseBJ1rQ3dYL6Lfsg3L wBdQ== X-Received: by 10.152.37.99 with SMTP id x3mr416678laj.7.1394674847165; Wed, 12 Mar 2014 18:40:47 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.205.73 with HTTP; Wed, 12 Mar 2014 18:40:07 -0700 (PDT) In-Reply-To: References: Date: Thu, 13 Mar 2014 10:40:07 +0900 X-Google-Sender-Auth: o3-kGCAfrFUZAwaV3t25cMeK-jM Message-ID: To: Andrey Andreev Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=089e0158b87cd7b1d804f4730ad4 Subject: Re: Revert session_serializer_name(), session_gc() From: yohgaki@ohgaki.net (Yasuo Ohgaki) --089e0158b87cd7b1d804f4730ad4 Content-Type: text/plain; charset=UTF-8 Hi Andrey, On Thu, Mar 13, 2014 at 8:43 AM, Andrey Andreev wrote: > > I'll fix root cause of GC issue later. GC should not depend on luck. > > What do you mean you'll fix it? What would the solution to that be? Save handler may keep & check last GC time. If it's over session.expire, perform GC. Issue is that "session data that should be deleted" is not deleted and could be alive long term due to current design. Current design is good enough for many usage, but it is not the best practice obviously. "Keep & check last GC time" requires additional overhead for every request. This is the reason why I prefer to have session_gc() and encourage users to use it properly. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --089e0158b87cd7b1d804f4730ad4--