Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73069
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.174 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAPhkiZx=0Vr5p=7VZJD4PeD0ub-khSVMw3G03QhO8CC4xxm11A@mail.gmail.com>
References: <CAPhkiZx=0Vr5p=7VZJD4PeD0ub-khSVMw3G03QhO8CC4xxm11A@mail.gmail.com>
Date: Wed, 12 Mar 2014 07:37:31 +0900
Message-ID: <CAGa2bXZTU5HzM4oXyiu0PnS=W2Oz1uLP_BnyWBUXyYUTO0tMYg@mail.gmail.com>
To: Andrey Andreev <narf@devilix.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bfd022afe624704f45c5f97
Subject: Re: Revert session_serializer_name(), session_gc()
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--047d7bfd022afe624704f45c5f97
Content-Type: text/plain; charset=UTF-8

Hi Andrey,

On Tue, Mar 11, 2014 at 10:37 PM, Andrey Andreev <narf@devilix.net> wrote:

> I just saw this in the 5.6-alpha1 changelog:
>
>    - Implemented Request #54649 (Create session_serializer_name()). (Yasuo)
>     ...
>    - Implemented Request #11100 (session_gc() function). (Yasuo)
>
>
> I didn't find an RFC and I don't know a way to search for a discussion
> on internals (Google doesn't find one).
>
> session_serializer_name(): https://bugs.php.net/bug.php?id=54649
>
> I don't think that this should've been implemented, especially with
> the reasoning from the feature request ... The same could be applied
> to all session ini options and especially now since session_start()
> accepts them, it's useless IMO.
>
> session_gc() was added in a similar fashion:
> https://bugs.php.net/bug.php?id=11100
>
> There's already a comment about how the same thing can be achieved by
> overloading SessionHandler::gc(), but a user could also just alter
> session.gc_divisor, session.gc_probability to ensure that the garbage
> collector is started.
>

Users want to have contorl *when* gc is performed rather than luck. This is
reasonable. IMO.


>  And while session_serializer_name() is just redundant, session_gc()
> could cause performance issues.
>

There is session_module_name(), why not session_serializer_name()?
Many 3rd party save handler implements many serializer.

session_gc() is nothing to do with performance. Users may abuse. The same
argument applies to gc probability.

 I'd strongly suggest that these 2 functions should be removed before
> PHP 5.6 is officially released.
>

These are simple additional APIs.
If your argument applies, there should be number of new RFCs.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--047d7bfd022afe624704f45c5f97--