Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73066
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.213.50 as permitted sender)
MIME-Version: 1.0
Date: Tue, 11 Mar 2014 15:37:44 +0200
Message-ID: <CAPhkiZx=0Vr5p=7VZJD4PeD0ub-khSVMw3G03QhO8CC4xxm11A@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>, Yasuo Ohgaki <yohgaki@ohgaki.net>
Content-Type: text/plain; charset=UTF-8
Subject: Revert session_serializer_name(), session_gc()
From: narf@devilix.net (Andrey Andreev)

Hello,

I just saw this in the 5.6-alpha1 changelog:

   - Implemented Request #54649 (Create session_serializer_name()). (Yasuo)
    ...
   - Implemented Request #11100 (session_gc() function). (Yasuo)


I didn't find an RFC and I don't know a way to search for a discussion
on internals (Google doesn't find one).

session_serializer_name(): https://bugs.php.net/bug.php?id=54649

I don't think that this should've been implemented, especially with
the reasoning from the feature request ... The same could be applied
to all session ini options and especially now since session_start()
accepts them, it's useless IMO.

session_gc() was added in a similar fashion:
https://bugs.php.net/bug.php?id=11100

There's already a comment about how the same thing can be achieved by
overloading SessionHandler::gc(), but a user could also just alter
session.gc_divisor, session.gc_probability to ensure that the garbage
collector is started.
And while session_serializer_name() is just redundant, session_gc()
could cause performance issues.

I'd strongly suggest that these 2 functions should be removed before
PHP 5.6 is officially released.

Regards,
Andrey Andreev.