Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:73052
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAHMUw2GaSuC8F0u7MOuKgcdROnvfWPuuhxrrgtNsKWF8Q28Oig@mail.gmail.com>
References: <CAHMUw2GjeDRveLK99Q8U08y-3zqftAN8mLKPt=yikjT2BrNdBQ@mail.gmail.com>
	<CAMUwpuTxoiR-QhniYsBAebec0rusiu+FHoXx2hY=VY=z9um_mQ@mail.gmail.com>
	<CACQesk5+Wvy_kY9qjR6Ma9ChFjyvRjJrXa9DQYjOh43_uNu3hA@mail.gmail.com>
	<CACQesk6jiYdzzibjzr2ba5XC3U1hSRCnj1gyaC1KNDJMaP1+sQ@mail.gmail.com>
	<CAHMUw2HAOpM8E93rEyo6YVQab36sYbi4ssLoQPX+Kk8MMEJ-nA@mail.gmail.com>
	<CAHMUw2HPbFKX5pds-BY0NLjyfX_LGONzYYL68t_nj7fDgObzBQ@mail.gmail.com>
	<CAH-PCH5Onh0ssbEsKp5s6RNeOd6+3OphTSgak5rNph2RgDF+yA@mail.gmail.com>
	<CACQesk5nZTfdSULhTjmWw5xm_xresvVjEoVHfmESJm+vbMNOKw@mail.gmail.com>
	<CAHMUw2GaSuC8F0u7MOuKgcdROnvfWPuuhxrrgtNsKWF8Q28Oig@mail.gmail.com>
Date: Tue, 11 Mar 2014 00:20:59 +0800
Message-ID: <CAHMUw2HGnKLaEKSehA6a74iEBaYuUTqixAKwXRXn15WVbYr-ZA@mail.gmail.com>
To: Etienne Kneuss <colder@php.net>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, Julien Pauli <jpauli@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bf0f4fc2b432d04f442fdcc
Subject: Re: [PHP-DEV] [PR 614] ArrayObject and isset() / empty() behaviour
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--047d7bf0f4fc2b432d04f442fdcc
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 10, 2014 at 9:58 PM, Tjerk Meesters <tjerk.meesters@gmail.com>w=
rote:

> Hi Etienne,
>
>
> On Mon, Mar 10, 2014 at 9:26 PM, Etienne Kneuss <colder@php.net> wrote:
>
>>
>>
>>
>> On Mon, Mar 10, 2014 at 1:43 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>>
>>>
>>>
>>>
>>> On Sat, Mar 8, 2014 at 10:56 AM, Tjerk Meesters <
>>> tjerk.meesters@gmail.com> wrote:
>>>
>>>> On Sat, Mar 8, 2014 at 8:27 AM, Tjerk Meesters <
>>>> tjerk.meesters@gmail.com>wrote:
>>>>
>>>> > Hi Etienne,
>>>> >
>>>> > Thanks for your input, much appreciated.
>>>> >
>>>> > I have moved the decision up the chain as you suggested; the results
>>>> can
>>>> > be found here:
>>>> >
>>>> > https://github.com/datibbaw/php-src/compare/php:PHP-5.4...bug66834a
>>>> >
>>>>
>>>> >
>>>> > It's suffering from a few memory leaks which can be fixed,
>>>> >
>>>>
>>>> They are fixed now and a new PR has been opened:
>>>>
>>>> https://github.com/php/php-src/pull/616
>>>>
>>>>
>>> Hi Etienne,
>>>
>>> Are you fine with the changes in the PR?
>>>
>>>
>> Two things:
>>
>> 1) Where is this planned to be merged? Is it really 5.4 ? As is the PR i=
s
>> no longer a simple bug fix and while I agree it should be changed that w=
ay,
>> it might introduce hard-to-track BC breaks.
>>
>
> After a short discussion on IRC I'm moving the branch to target 5.6
> instead.
>
>
>> 2) Seems to me that with this PR, part of the hack present in ArrayObjec=
t
>> in the has_dimension handler is no longer necessary, as it might be doin=
g
>> to value-check twice now.
>>
>
> I'll start looking into this now. Thanks for the heads up :)
>

I've updated and cleaned up ext/spl; the most notable change is code
removal according to a changed definition of zend_object_has_dimension_t:

typedef int (*zend_object_has_dimension_t)(zval *object, zval *member
TSRMLS_DC);

PR: https://github.com/php/php-src/pull/621

Let me know if you see any other issues; I'm fine with reverting the
typedef change if that could be an issue.


>
>
>>
>>
>>  Best,
>>
>>  --
>>> Ferenc Kov=E1cs
>>> @Tyr43l - http://tyrael.hu
>>>
>>
>>
>>
>> --
>> Etienne Kneuss
>> http://www.colder.ch
>>
>
>
>
> --
> --
> Tjerk
>



--=20
--
Tjerk

--047d7bf0f4fc2b432d04f442fdcc--