Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73051 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 5054 invoked from network); 10 Mar 2014 13:58:36 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Mar 2014 13:58:36 -0000 Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.171 as permitted sender) X-PHP-List-Original-Sender: tjerk.meesters@gmail.com X-Host-Fingerprint: 209.85.220.171 mail-vc0-f171.google.com Received: from [209.85.220.171] ([209.85.220.171:56958] helo=mail-vc0-f171.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 17/C1-29996-A05CD135 for ; Mon, 10 Mar 2014 08:58:35 -0500 Received: by mail-vc0-f171.google.com with SMTP id lg15so642663vcb.30 for ; Mon, 10 Mar 2014 06:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=zjrho4/DQwmUkr2ueU+Y47gA+LvbMdJPuVpHGb2GdvE=; b=YpzEt0/pOLIdxH9ZwgrRUHaLDfNT0Ht5TeNvzShaE+OeLoEpRpgxspCkMyNte9NYYl aDgqtOArdVAYij2K9D3vlyo8JmfXgpcL1BTzQRgOamUmWfeXUy/jXPHcOJtVoUBmCg3p vIGZ0SrPqZcKZzlmbeYCfRVM6t0Sv0evi5bmX2gupS1zy61O1Gb5PzmWlcLVeEpwgvuc D14BVMEBB2qUO34VdMrejrtHY0fZ379AASGpzMsKRxt4ZRjFLNYotqC6Qm7mXVRQ0MCs bVVg65z5d5jTUlzNtEKYIcs/nyK4EenBZSvpsZp1Tej7XT2N6HbZBILtjQ6hYxMsQi7F cpAA== MIME-Version: 1.0 X-Received: by 10.52.171.68 with SMTP id as4mr22722485vdc.0.1394459911527; Mon, 10 Mar 2014 06:58:31 -0700 (PDT) Received: by 10.58.55.131 with HTTP; Mon, 10 Mar 2014 06:58:31 -0700 (PDT) In-Reply-To: References: Date: Mon, 10 Mar 2014 21:58:31 +0800 Message-ID: To: Etienne Kneuss Cc: Ferenc Kovacs , Julien Pauli , PHP Internals Content-Type: multipart/alternative; boundary=047d7b6dbd9aae260304f440ffb5 Subject: Re: [PHP-DEV] [PR 614] ArrayObject and isset() / empty() behaviour From: tjerk.meesters@gmail.com (Tjerk Meesters) --047d7b6dbd9aae260304f440ffb5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Etienne, On Mon, Mar 10, 2014 at 9:26 PM, Etienne Kneuss wrote: > > > > On Mon, Mar 10, 2014 at 1:43 PM, Ferenc Kovacs wrote: > >> >> >> >> On Sat, Mar 8, 2014 at 10:56 AM, Tjerk Meesters > > wrote: >> >>> On Sat, Mar 8, 2014 at 8:27 AM, Tjerk Meesters >> >wrote: >>> >>> > Hi Etienne, >>> > >>> > Thanks for your input, much appreciated. >>> > >>> > I have moved the decision up the chain as you suggested; the results >>> can >>> > be found here: >>> > >>> > https://github.com/datibbaw/php-src/compare/php:PHP-5.4...bug66834a >>> > >>> >>> > >>> > It's suffering from a few memory leaks which can be fixed, >>> > >>> >>> They are fixed now and a new PR has been opened: >>> >>> https://github.com/php/php-src/pull/616 >>> >>> >> Hi Etienne, >> >> Are you fine with the changes in the PR? >> >> > Two things: > > 1) Where is this planned to be merged? Is it really 5.4 ? As is the PR is > no longer a simple bug fix and while I agree it should be changed that wa= y, > it might introduce hard-to-track BC breaks. > After a short discussion on IRC I'm moving the branch to target 5.6 instead= . > 2) Seems to me that with this PR, part of the hack present in ArrayObject > in the has_dimension handler is no longer necessary, as it might be doing > to value-check twice now. > I'll start looking into this now. Thanks for the heads up :) > > > Best, > > -- >> Ferenc Kov=E1cs >> @Tyr43l - http://tyrael.hu >> > > > > -- > Etienne Kneuss > http://www.colder.ch > --=20 -- Tjerk --047d7b6dbd9aae260304f440ffb5--