Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:73050 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 2095 invoked from network); 10 Mar 2014 13:27:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Mar 2014 13:27:23 -0000 Authentication-Results: pb1.pair.com header.from=ekneuss@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ekneuss@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.171 as permitted sender) X-PHP-List-Original-Sender: ekneuss@gmail.com X-Host-Fingerprint: 74.125.82.171 mail-we0-f171.google.com Received: from [74.125.82.171] ([74.125.82.171:43460] helo=mail-we0-f171.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CF/31-29996-8BDBD135 for ; Mon, 10 Mar 2014 08:27:20 -0500 Received: by mail-we0-f171.google.com with SMTP id t61so8558126wes.2 for ; Mon, 10 Mar 2014 06:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=pUU8/93TN6yDdzF7ri2ii7DkkkKbyvqrmWA2XWHRG1w=; b=ZZ3oSQJdspA3BAhqZIxsURSrw9FesDk0o7JMZARQsSKygpmFkQkUaxWAb4diPobhus 1Mh0vzYCdWMhvqu1R8RdvxzQVqBqn2jr6hgsDz9diqf4HpYsNFOimky3kX3iDtPkMDg3 yflBvjnol14wG4/ZtMU078xNu3jaW9CYGa+UevZVWAv4rSgAo25ong9ke8EfJcsCTMgw HGH58In/gS21kp6ZPuQTfonN+hSX2HJ/Fo90UlRa0REs0spPab1FTxYubaPeAZ5pCB+Y gh6js07aXyhLD54PLy0kLnaSV5ZWArt2MlBGnwEJ4YlE9qDoaKp7yY1MSn4M1CQjhtCn ZxmA== X-Received: by 10.180.149.206 with SMTP id uc14mr8100098wib.10.1394458037764; Mon, 10 Mar 2014 06:27:17 -0700 (PDT) MIME-Version: 1.0 Sender: ekneuss@gmail.com Received: by 10.216.47.67 with HTTP; Mon, 10 Mar 2014 06:26:47 -0700 (PDT) In-Reply-To: References: Date: Mon, 10 Mar 2014 14:26:47 +0100 X-Google-Sender-Auth: Eh35Xi2WEw_GPoZtRegsQCUlMBI Message-ID: To: Ferenc Kovacs Cc: Tjerk Meesters , Julien Pauli , PHP Internals Content-Type: multipart/alternative; boundary=001a11c38008fec62904f4408fdc Subject: Re: [PHP-DEV] [PR 614] ArrayObject and isset() / empty() behaviour From: colder@php.net (Etienne Kneuss) --001a11c38008fec62904f4408fdc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, Mar 10, 2014 at 1:43 PM, Ferenc Kovacs wrote: > > > > On Sat, Mar 8, 2014 at 10:56 AM, Tjerk Meesters wrote: > >> On Sat, Mar 8, 2014 at 8:27 AM, Tjerk Meesters > >wrote: >> >> > Hi Etienne, >> > >> > Thanks for your input, much appreciated. >> > >> > I have moved the decision up the chain as you suggested; the results c= an >> > be found here: >> > >> > https://github.com/datibbaw/php-src/compare/php:PHP-5.4...bug66834a >> > >> >> > >> > It's suffering from a few memory leaks which can be fixed, >> > >> >> They are fixed now and a new PR has been opened: >> >> https://github.com/php/php-src/pull/616 >> >> > Hi Etienne, > > Are you fine with the changes in the PR? > > Two things: 1) Where is this planned to be merged? Is it really 5.4 ? As is the PR is no longer a simple bug fix and while I agree it should be changed that way, it might introduce hard-to-track BC breaks. 2) Seems to me that with this PR, part of the hack present in ArrayObject in the has_dimension handler is no longer necessary, as it might be doing to value-check twice now. Best, --=20 > Ferenc Kov=C3=A1cs > @Tyr43l - http://tyrael.hu > --=20 Etienne Kneuss http://www.colder.ch --001a11c38008fec62904f4408fdc--