Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72919
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAPhkiZwsndt-sC+wChyXS03+kDvSKEWoK=jKwGjuhLy1gk7Z1g@mail.gmail.com>
References: <CAPhkiZwsndt-sC+wChyXS03+kDvSKEWoK=jKwGjuhLy1gk7Z1g@mail.gmail.com>
Date: Wed, 5 Mar 2014 13:36:38 +0100
Message-ID: <CAF+90c9e3YF09Sv-h=f72OGUEFifO8w4ZE2neV=4fijCh3AYsw@mail.gmail.com>
To: Andrey Andreev <narf@devilix.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>, Derick Rethans <derick@php.net>
Content-Type: multipart/alternative; boundary=001a11c1f540a401ef04f3db453d
Subject: Re: [PHP-DEV] Stricter error handling in mcrypt extension
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11c1f540a401ef04f3db453d
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Mar 4, 2014 at 9:32 PM, Andrey Andreev <narf@devilix.net> wrote:

> Hey,
>
> Speaking of bugs in MCrypt and IVs ... in ECB mode it complains if you
> don't pass an IV, even though it is ignored afterwards.
>

You're probably referring to mcrypt_generic here, rather than
mcrypt_encrypt. I can bring that function in line with mcrypt_encrypt, i.e.
add the same error checks and make the IV only required if the mode
requires it.

However I'm not sure what kind of return value I should use with this
function. Currently it returns a long result, which is 0 on success and a
negative number on error. However mcrypt does not define error codes for
all possible error conditions, e.g. while it has a code for invalid key
sizes, it doesn't have a code for invalid IV sizes.

Personally I'd just switch it to true/false for success/error, as the
warnings already tell you what kind of error occurred. Would that be okay
with you, Derick?

Nikita

--001a11c1f540a401ef04f3db453d--