Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:72902 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 43905 invoked from network); 2 Mar 2014 17:54:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Mar 2014 17:54:56 -0000 Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:50873] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 73/A2-27008-F6073135 for ; Sun, 02 Mar 2014 12:54:56 -0500 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id C95AC10D685; Sun, 2 Mar 2014 17:54:52 +0000 (GMT) Date: Sun, 2 Mar 2014 12:54:52 -0500 (EST) X-X-Sender: derick@whisky.home.derickrethans.nl To: Pierre Joye cc: PHP internals , Nikita Popov In-Reply-To: Message-ID: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] Stricter error handling in mcrypt extension From: derick@php.net (Derick Rethans) On Sun, 2 Mar 2014, Pierre Joye wrote: > On Mar 2, 2014 6:07 PM, "Derick Rethans" wrote: > . > > I've added some comments, which those fixed, feel free to commit > > this. > > As Tyrael said, these changes intruduce BC breaks. Per se they should > not be allowed, but what this patch may be one of these exceptions we > allow from time to time. Small rfc+vote should solve that quickly. Nonsense. As extension maintainer I most definitely classify them as bug fixes. You really want to argue *for* bad security in an extension? cheers, Derick