Newsgroups: php.internals,php.pecl.dev
Path: news.php.net
Xref: news.php.net php.internals:72875 php.pecl.dev:11588
Return-Path: <pierre.php@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 97637 invoked from network); 28 Feb 2014 18:33:23 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 28 Feb 2014 18:33:23 -0000
Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.46 as permitted sender)
X-PHP-List-Original-Sender: pierre.php@gmail.com
X-Host-Fingerprint: 209.85.216.46 mail-qa0-f46.google.com  
Received: from [209.85.216.46] ([209.85.216.46:48578] helo=mail-qa0-f46.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 77/B6-64896-E66D0135 for <internals@lists.php.net>; Fri, 28 Feb 2014 13:33:20 -0500
Received: by mail-qa0-f46.google.com with SMTP id i13so1011980qae.19
        for <multiple recipients>; Fri, 28 Feb 2014 10:33:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=BYkWaY5Z3HZzfPiNupfBg0UFjjFUT/b0lyXIGmeFSEM=;
        b=fyHXf6F/TvMfE2roNvjCxLORSK5BTvffGZvXbV4Q0HoipxdQ5zYvinrQQT05+SdvJn
         UKZK+TiiOxDh6oYzhImw6Dc7+hoZcmNJsaxY36MSa2qk6vK27loTi6OU/TrLptkI0ZeI
         3bnnlTC0DurZSyPlS/hK7UshdsR43ufDdtCtilMdg0Nt9uZD/SfYvlfFT6WL86OA9nIL
         QSCj0nCDNpJsUzkqOn15MFjXx8gFxRjaSH/0Ctd40/01BfcEz/uaQnbnG/wgkX75n15x
         SECWD/sCh1wmIkkUxaEMZl2XoGt9z0J1hy+vjcvog/7Sfjtc2iRKCyLJMxhJnpmWDrLO
         uQPw==
MIME-Version: 1.0
X-Received: by 10.229.66.202 with SMTP id o10mr5869637qci.7.1393612396089;
 Fri, 28 Feb 2014 10:33:16 -0800 (PST)
Received: by 10.140.18.145 with HTTP; Fri, 28 Feb 2014 10:33:16 -0800 (PST)
In-Reply-To: <alpine.DEB.2.10.1402281308270.9526@whisky.home.derickrethans.nl>
References: <alpine.DEB.2.10.1402281137160.9526@whisky.home.derickrethans.nl>
	<CAH-PCH4FBH+8wKLSfgNReh4GPT+KQfYm=jy6vcXAgc6+vu=keA@mail.gmail.com>
	<CAH-PCH6y2MyS4BLFDCFg8S+ihujP6B3apSJx71TBZdCR2FAryg@mail.gmail.com>
	<alpine.DEB.2.10.1402281308270.9526@whisky.home.derickrethans.nl>
Date: Fri, 28 Feb 2014 19:33:16 +0100
Message-ID: <CAEZPtU6E288ERjacJptaGCF2Tn2XyLr7=-J2+goH-AoGVBeomw@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, PHP Developers Mailing List <internals@lists.php.net>, 
	PECL Announce <pecl-dev@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Stupid and incorrect version checks.
From: pierre.php@gmail.com (Pierre Joye)

On Fri, Feb 28, 2014 at 7:13 PM, Derick Rethans <derick@php.net> wrote:
> On Fri, 28 Feb 2014, Ferenc Kovacs wrote:
>
>> On Fri, Feb 28, 2014 at 6:00 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>>
>> > On Fri, Feb 28, 2014 at 5:47 PM, Derick Rethans <derick@php.net> wrote:
>> >
>> >> So, when trying to upload the latest Xdebug release I get this
>> >> *incorrect* nonsense preventing me from making a release:
>> >>
>> >>         ERROR:
>> >>
>> >>                 The compliance between the package version in package.xml
>> >> and
>> >>         extension source code couldn't be reliably determined. This check
>> >> fixes
>> >>         the (unintended) version mismatch in phpinfo() and the PECL
>> >> website.
>> >>                 To pass please #define PHP_MYEXTNAME_VERSION "2.2.4" in
>> >> your
>> >>         php_myextname.h or any other header file and use it for
>> >>         zend_module_entry definition.
>> >>                 Both version strings have to match.
>> >>
>> >>
>> >> This pisses me off. Do not ever block uploads because of some arbitrary
>> >> rule of how you should think my code should look like. The versions
>> >> numbers are correct and properly defined with a constant:
>> >>
>> >>         php_xdebug.h:#define XDEBUG_VERSION    "2.2.4"
>>
>> and here is a link to the relevant discussion about this change:
>> http://comments.gmane.org/gmane.comp.php.devel/82446
>
> Perhaps, I don't mind a check for an incorrect version, but when you
> decide to block things because you can not determine anything, then it's
> just stupid. Hannes very nicely summed that up in this post (even though
> *that* is about the LICENSE file requirement).
>
> http://permalink.gmane.org/gmane.comp.php.pecl.devel/10336
>
> and in:
>
> http://permalink.gmane.org/gmane.comp.php.pecl.devel/10339
>
> And Johannes in (more on topic with the version nr):
>
> http://permalink.gmane.org/gmane.comp.php.pecl.devel/10342
>
> But the problem is not checking for it, the problem is blocking an
> upload of a package that is perfectly valid and *correct*.

The package is not correct, while working.

We have discussed the naming and this requirement years ago. Many
developers have annoyed by the lack of checks for the version, license
or other things making the package meta information wrong. This has
been a disturbing point for our users and distributions. Now you moved
the checks to warning, allowing one to release invalid packages,
without even waiting for a reply or answer. Just like what happened
last time for the license check. This is an unacceptable behavior. And
that pisses us off, if I may use the same wording that you do.

Please update your code and that's it. There is no point to discuss or
argue about this for ages while it takes you 5 seconds to do it, even
more as you are the only one complaining about that.

Cheers.
-- 
Pierre

@pierrejoye | http://www.libgd.org