Newsgroups: php.internals,php.pecl.dev Path: news.php.net Xref: news.php.net php.internals:72873 php.pecl.dev:11586 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94540 invoked from network); 28 Feb 2014 18:13:38 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Feb 2014 18:13:38 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:35538] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D3/26-64896-0D1D0135 for ; Fri, 28 Feb 2014 13:13:37 -0500 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id A68F910D3A2; Fri, 28 Feb 2014 18:13:31 +0000 (GMT) Date: Fri, 28 Feb 2014 13:13:29 -0500 (EST) X-X-Sender: derick@whisky.home.derickrethans.nl To: Ferenc Kovacs cc: PHP Developers Mailing List , PECL Announce In-Reply-To: Message-ID: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] Stupid and incorrect version checks. From: derick@php.net (Derick Rethans) On Fri, 28 Feb 2014, Ferenc Kovacs wrote: > On Fri, Feb 28, 2014 at 6:00 PM, Ferenc Kovacs wrote: > > > On Fri, Feb 28, 2014 at 5:47 PM, Derick Rethans wrote: > > > >> So, when trying to upload the latest Xdebug release I get this > >> *incorrect* nonsense preventing me from making a release: > >> > >> ERROR: > >> > >> The compliance between the package version in package.xml > >> and > >> extension source code couldn't be reliably determined. This check > >> fixes > >> the (unintended) version mismatch in phpinfo() and the PECL > >> website. > >> To pass please #define PHP_MYEXTNAME_VERSION "2.2.4" in > >> your > >> php_myextname.h or any other header file and use it for > >> zend_module_entry definition. > >> Both version strings have to match. > >> > >> > >> This pisses me off. Do not ever block uploads because of some arbitrary > >> rule of how you should think my code should look like. The versions > >> numbers are correct and properly defined with a constant: > >> > >> php_xdebug.h:#define XDEBUG_VERSION "2.2.4" > > and here is a link to the relevant discussion about this change: > http://comments.gmane.org/gmane.comp.php.devel/82446 Perhaps, I don't mind a check for an incorrect version, but when you decide to block things because you can not determine anything, then it's just stupid. Hannes very nicely summed that up in this post (even though *that* is about the LICENSE file requirement). http://permalink.gmane.org/gmane.comp.php.pecl.devel/10336 and in: http://permalink.gmane.org/gmane.comp.php.pecl.devel/10339 And Johannes in (more on topic with the version nr): http://permalink.gmane.org/gmane.comp.php.pecl.devel/10342 But the problem is not checking for it, the problem is blocking an upload of a package that is perfectly valid and *correct*. cheers, Derick