Newsgroups: php.internals,php.pecl.dev
Path: news.php.net
Xref: news.php.net php.internals:72868 php.pecl.dev:11583
Return-Path: <tyra3l@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 79204 invoked from network); 28 Feb 2014 17:04:13 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 28 Feb 2014 17:04:13 -0000
Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.169 as permitted sender)
X-PHP-List-Original-Sender: tyra3l@gmail.com
X-Host-Fingerprint: 209.85.216.169 mail-qc0-f169.google.com  
Received: from [209.85.216.169] ([209.85.216.169:58239] helo=mail-qc0-f169.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id BC/D2-64896-A81C0135 for <internals@lists.php.net>; Fri, 28 Feb 2014 12:04:11 -0500
Received: by mail-qc0-f169.google.com with SMTP id e9so1055078qcy.0
        for <multiple recipients>; Fri, 28 Feb 2014 09:04:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=+/tDHpIEs6Tp4ReiMpHxVuvlHSu3+KE19znBHFktAbk=;
        b=Km5QQNcXLqRuEijpVJIY7crpAgFi08rrBBS0omO9aFeKgiMoa3dXBj5HwMN6TfjpNL
         eQg+3XnirI4qVQj/uSEeZD14heY99NM/ENIGGxHJbZz5GULpOO7YrfixwgOlns9yKYVs
         Dqb8Tk7Q1RoIQKszzmcHuQLDzJV/IASAVW57ji/3x9D1V27RAmCRLvgoiLZHLDtuHPFu
         XlrWX8DzgOJ9gh45TLoslxgSsbgt5jcHm4XeFyVeDdS9xqvIXYQY6KXU6QPVcSfRdk+0
         +V+JLuhEOqrS9v7fc+ZgDwZlyDA897E8TAh01E8SWGJW21nV7RdrXAO+X3lX+2WjFIlP
         FiPQ==
MIME-Version: 1.0
X-Received: by 10.140.39.212 with SMTP id v78mr4835603qgv.77.1393607046956;
 Fri, 28 Feb 2014 09:04:06 -0800 (PST)
Received: by 10.140.92.41 with HTTP; Fri, 28 Feb 2014 09:04:06 -0800 (PST)
In-Reply-To: <CAH-PCH4FBH+8wKLSfgNReh4GPT+KQfYm=jy6vcXAgc6+vu=keA@mail.gmail.com>
References: <alpine.DEB.2.10.1402281137160.9526@whisky.home.derickrethans.nl>
	<CAH-PCH4FBH+8wKLSfgNReh4GPT+KQfYm=jy6vcXAgc6+vu=keA@mail.gmail.com>
Date: Fri, 28 Feb 2014 18:04:06 +0100
Message-ID: <CAH-PCH6y2MyS4BLFDCFg8S+ihujP6B3apSJx71TBZdCR2FAryg@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: PHP Developers Mailing List <internals@lists.php.net>, PECL Announce <pecl-dev@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c12662fd8b7d04f37a6cae
Subject: Re: [PHP-DEV] Stupid and incorrect version checks.
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a11c12662fd8b7d04f37a6cae
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 28, 2014 at 6:00 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:

>
>
> On Fri, Feb 28, 2014 at 5:47 PM, Derick Rethans <derick@php.net> wrote:
>
>> So, when trying to upload the latest Xdebug release I get this
>> *incorrect* nonsense preventing me from making a release:
>>
>>         ERROR:
>>
>>                 The compliance between the package version in package.xm=
l
>> and
>>         extension source code couldn't be reliably determined. This chec=
k
>> fixes
>>         the (unintended) version mismatch in phpinfo() and the PECL
>> website.
>>                 To pass please #define PHP_MYEXTNAME_VERSION "2.2.4" in
>> your
>>         php_myextname.h or any other header file and use it for
>>         zend_module_entry definition.
>>                 Both version strings have to match.
>>
>>
>> This pisses me off. Do not ever block uploads because of some arbitrary
>> rule of how you should think my code should look like. The versions
>> numbers are correct and properly defined with a constant:
>>
>>         php_xdebug.h:#define XDEBUG_VERSION    "2.2.4"
>>
>> Requiring that this constant should ahve PHP in it is stupid and
>> arbitrary decision that doesn't help anybody. If and only *if* you want
>> to enforce those rules, do it in the *package* state, and *never* when
>> everything is ready to go to just be rejected.
>>
>> Besides that, the code that checks for this doesn't seem to be in PECL
>> web either:
>>
>>         derick@whisky:~ $ cd dev/php/peclweb
>>         [GIT: master]
>>
>>         derick@whisky:~/dev/php/peclweb $ git remote -v
>>         origin  git@git.php.net:/web/pecl.git (fetch)
>>         origin  git@git.php.net:/web/pecl.git (push)
>>
>>         [GIT: master]
>>         derick@whisky:~/dev/php/peclweb $ git pull
>>         Already up-to-date.
>>
>>         [GIT: master]
>>         derick@whisky:~/dev/php/peclweb $ grep -r "compliance between" *
>>
>> It looks like the last commit was in december 2012 which is clearly a li=
e.
>> Where is the current code?
>>
>> cheers,
>> Derick
>>
>> --
>> http://derickrethans.nl | http://xdebug.org
>> Like Xdebug? Consider a donation: http://xdebug.org/donate.php
>> twitter: @derickr and @xdebug
>> Posted with an email client that doesn't mangle email: alpine
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
> the current code is in the old_auth branch.
>
> --
> Ferenc Kov=C3=A1cs
> @Tyr43l - http://tyrael.hu
>

and here is a link to the relevant discussion about this change:
http://comments.gmane.org/gmane.comp.php.devel/82446


--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a11c12662fd8b7d04f37a6cae--