Newsgroups: php.internals,php.pecl.dev
Path: news.php.net
Xref: news.php.net php.internals:72867 php.pecl.dev:11582
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.176 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1402281137160.9526@whisky.home.derickrethans.nl>
References: <alpine.DEB.2.10.1402281137160.9526@whisky.home.derickrethans.nl>
Date: Fri, 28 Feb 2014 18:00:13 +0100
Message-ID: <CAH-PCH4FBH+8wKLSfgNReh4GPT+KQfYm=jy6vcXAgc6+vu=keA@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: PHP Developers Mailing List <internals@lists.php.net>, PECL Announce <pecl-dev@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c1db6c16a22004f37a5ff9
Subject: Re: [PHP-DEV] Stupid and incorrect version checks.
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a11c1db6c16a22004f37a5ff9
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 28, 2014 at 5:47 PM, Derick Rethans <derick@php.net> wrote:

> So, when trying to upload the latest Xdebug release I get this
> *incorrect* nonsense preventing me from making a release:
>
>         ERROR:
>
>                 The compliance between the package version in package.xml
> and
>         extension source code couldn't be reliably determined. This check
> fixes
>         the (unintended) version mismatch in phpinfo() and the PECL
> website.
>                 To pass please #define PHP_MYEXTNAME_VERSION "2.2.4" in
> your
>         php_myextname.h or any other header file and use it for
>         zend_module_entry definition.
>                 Both version strings have to match.
>
>
> This pisses me off. Do not ever block uploads because of some arbitrary
> rule of how you should think my code should look like. The versions
> numbers are correct and properly defined with a constant:
>
>         php_xdebug.h:#define XDEBUG_VERSION    "2.2.4"
>
> Requiring that this constant should ahve PHP in it is stupid and
> arbitrary decision that doesn't help anybody. If and only *if* you want
> to enforce those rules, do it in the *package* state, and *never* when
> everything is ready to go to just be rejected.
>
> Besides that, the code that checks for this doesn't seem to be in PECL
> web either:
>
>         derick@whisky:~ $ cd dev/php/peclweb
>         [GIT: master]
>
>         derick@whisky:~/dev/php/peclweb $ git remote -v
>         origin  git@git.php.net:/web/pecl.git (fetch)
>         origin  git@git.php.net:/web/pecl.git (push)
>
>         [GIT: master]
>         derick@whisky:~/dev/php/peclweb $ git pull
>         Already up-to-date.
>
>         [GIT: master]
>         derick@whisky:~/dev/php/peclweb $ grep -r "compliance between" *
>
> It looks like the last commit was in december 2012 which is clearly a lie=
.
> Where is the current code?
>
> cheers,
> Derick
>
> --
> http://derickrethans.nl | http://xdebug.org
> Like Xdebug? Consider a donation: http://xdebug.org/donate.php
> twitter: @derickr and @xdebug
> Posted with an email client that doesn't mangle email: alpine
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
the current code is in the old_auth branch.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a11c1db6c16a22004f37a5ff9--