Newsgroups: php.internals,php.pecl.dev
Path: news.php.net
Xref: news.php.net php.internals:72866 php.pecl.dev:11581
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender)
Date: Fri, 28 Feb 2014 11:47:34 -0500 (EST)
To: PHP Developers Mailing List <internals@lists.php.net>, 
    pecl-dev@lists.php.net
Message-ID: <alpine.DEB.2.10.1402281137160.9526@whisky.home.derickrethans.nl>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Stupid and incorrect version checks.
From: derick@php.net (Derick Rethans)

So, when trying to upload the latest Xdebug release I get this 
*incorrect* nonsense preventing me from making a release:

	ERROR:

		The compliance between the package version in package.xml and 
	extension source code couldn't be reliably determined. This check fixes 
	the (unintended) version mismatch in phpinfo() and the PECL website.
		To pass please #define PHP_MYEXTNAME_VERSION "2.2.4" in your 
	php_myextname.h or any other header file and use it for 
	zend_module_entry definition.
		Both version strings have to match.


This pisses me off. Do not ever block uploads because of some arbitrary 
rule of how you should think my code should look like. The versions 
numbers are correct and properly defined with a constant:

	php_xdebug.h:#define XDEBUG_VERSION    "2.2.4"

Requiring that this constant should ahve PHP in it is stupid and 
arbitrary decision that doesn't help anybody. If and only *if* you want 
to enforce those rules, do it in the *package* state, and *never* when 
everything is ready to go to just be rejected.

Besides that, the code that checks for this doesn't seem to be in PECL 
web either:

	derick@whisky:~ $ cd dev/php/peclweb
	[GIT: master]

	derick@whisky:~/dev/php/peclweb $ git remote -v
	origin	git@git.php.net:/web/pecl.git (fetch)
	origin	git@git.php.net:/web/pecl.git (push)

	[GIT: master]
	derick@whisky:~/dev/php/peclweb $ git pull
	Already up-to-date.

	[GIT: master]
	derick@whisky:~/dev/php/peclweb $ grep -r "compliance between" *

It looks like the last commit was in december 2012 which is clearly a lie.
Where is the current code?

cheers,
Derick

-- 
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug
Posted with an email client that doesn't mangle email: alpine