Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72690
Return-Path: <pierre.php@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 15888 invoked from network); 18 Feb 2014 17:59:20 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 18 Feb 2014 17:59:20 -0000
Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.45 as permitted sender)
X-PHP-List-Original-Sender: pierre.php@gmail.com
X-Host-Fingerprint: 209.85.216.45 mail-qa0-f45.google.com  
Received: from [209.85.216.45] ([209.85.216.45:57275] helo=mail-qa0-f45.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 4C/67-16937-67F93035 for <internals@lists.php.net>; Tue, 18 Feb 2014 12:59:19 -0500
Received: by mail-qa0-f45.google.com with SMTP id m5so10573634qaj.18
        for <internals@lists.php.net>; Tue, 18 Feb 2014 09:59:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=lvh9LsrDmWSefFMvEFk9LNZ8C1fqcFFrHWyncBEqYE0=;
        b=f1htXShakrdOhzA4LVwT4PCpO1gpQt3tIfpFxbj7S0aE8XB2hzFN64L1ZPQZmPRmS/
         WkVN0zIMC8SfizAHM2isSzOWuW+r197lS6Bnjd5HxRfnO7UDGQBwb4fzScTFFvIo3azv
         4Vt+xCvoT/rrDG+fI/iXrDR48begs1iSqw25ModCa1EobLlh4v/+W5uLNxpOTHARxkFg
         6ucywLSQviEBoOkI0JOLP28nWfDgjsi7Q2ipP4O6UIeFdBb8+P/IeBL2thcFc77qIDxa
         BbANBn7F3XKQJg1YtZN8b2jqlQuY2pPcsJJHPRkD3RT6+h7JYYMSjg++QXR2zX0D8VAP
         4pJg==
MIME-Version: 1.0
X-Received: by 10.229.183.200 with SMTP id ch8mr4600979qcb.17.1392746348469;
 Tue, 18 Feb 2014 09:59:08 -0800 (PST)
Received: by 10.140.18.145 with HTTP; Tue, 18 Feb 2014 09:59:08 -0800 (PST)
Received: by 10.140.18.145 with HTTP; Tue, 18 Feb 2014 09:59:08 -0800 (PST)
In-Reply-To: <530383AD.8060701@gmail.com>
References: <1392669755.3990.291.camel@guybrush>
	<CAMUwpuTuzjfjFZDPn4Mhf3ubA3Vb+CWzAQjx1AARfeK+P+99TQ@mail.gmail.com>
	<530383AD.8060701@gmail.com>
Date: Tue, 18 Feb 2014 18:59:08 +0100
Message-ID: <CAEZPtU7YNYJD6+FpVWWvexqZYnnW0jBv5RGKwDXtbgw4+fXNkQ@mail.gmail.com>
To: Terry Ellison <ellison.terry@gmail.com>
Cc: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>, 
	PHP internals <internals@lists.php.net>, Julien Pauli <jpauli@php.net>
Content-Type: multipart/alternative; boundary=001a1133916c5ce4fc04f2b20756
Subject: Re: [PHP-DEV] Usin ClangStatic Analyzer for zend_parse_parameters
From: pierre.php@gmail.com (Pierre Joye)

--001a1133916c5ce4fc04f2b20756
Content-Type: text/plain; charset=UTF-8

On Feb 18, 2014 11:01 PM, "Terry Ellison" <ellison.terry@gmail.com> wrote:
>
> Julien,
>>
>> <snip> Running this over one of my PHP builds I got those error reports:
>>
>> http://schlueters.de/zppcheck/ maybe somebody wants to go through them
>> and fix at least the trivial ones.
>
> By the way, your report seems to be listing entries twice -- at least as
the four PHPdbg SAPI ones.  In this case these are all a case of the "s"
parameter taking a char**, int* but phpdbg.c is passing in a char**, uint*.
 I'll issue a patch for Joe or Bob to review and push into PHP-5.6.
>
> Note that http://www.php.net/manual/en/internals2.funcs.php states that
the "s" parameter takes the addresses of char*, uint that is char** uint*
which is wrong.  Though why the length field should be signed seems odd to
me as a negative length makes no sense at all.

Right, that is something we have fixes in the int64 and sizet branch.

Cheers,
Pierre

--001a1133916c5ce4fc04f2b20756--