Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72687
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.215.10 cause and error)
To: Terry Ellison <ellison.terry@gmail.com>
Cc: Julien Pauli <jpauli@php.net>, PHP internals list
 <internals@lists.php.net>
In-Reply-To: <530383AD.8060701@gmail.com>
References: <1392669755.3990.291.camel@guybrush>
	 <CAMUwpuTuzjfjFZDPn4Mhf3ubA3Vb+CWzAQjx1AARfeK+P+99TQ@mail.gmail.com>
	 <530383AD.8060701@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 18 Feb 2014 18:14:00 +0100
Message-ID: <1392743640.3990.593.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Usin ClangStatic Analyzer for zend_parse_parameters
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Tue, 2014-02-18 at 16:00 +0000, Terry Ellison wrote:

> > <snip> Running this over one of my PHP builds I got those error reports:
> > http://schlueters.de/zppcheck/ maybe somebody wants to go through them
> > and fix at least the trivial ones.
> By the way, your report seems to be listing entries twice -- at least
> as the four PHPdbg SAPI ones. 

Interesting catch, have to investigate.

>  In this case these are all a case of the "s" parameter taking a
> char**, int* but phpdbg.c is passing in a char**, uint*.  I'll issue a
> patch for Joe or Bob to review and push into PHP-5.6.

Thanks.

> Note that http://www.php.net/manual/en/internals2.funcs.php states
> that the "s" parameter takes the addresses of char*, uint that is
> char** uint* which is wrong.  

Indeed a bug, will fix that right after sending this mail. Thanks for
noticing.

> Though why the length field should be signed seems odd to me as a
> negative length makes no sense at all.

- since it was defined that way
- since int is a simple choice
- since signed int has enough space for all expected strings
- since it can quite certainly passed to any library, it is
  unlikely a library will choose int4_t or such as length
  for strings and maxlength handling can now be in one place
- since it is supposed to be fixed (see recent looong discussion)

;-)

johannes