Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72684
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.179 as permitted sender)
Message-ID: <530383AD.8060701@gmail.com>
Date: Tue, 18 Feb 2014 16:00:45 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Julien Pauli <jpauli@php.net>, =?ISO-8859-1?Q?Johannes_Schl=FCter?=
 <johannes@schlueters.de>
CC: PHP internals list <internals@lists.php.net>
References: <1392669755.3990.291.camel@guybrush> <CAMUwpuTuzjfjFZDPn4Mhf3ubA3Vb+CWzAQjx1AARfeK+P+99TQ@mail.gmail.com>
In-Reply-To: <CAMUwpuTuzjfjFZDPn4Mhf3ubA3Vb+CWzAQjx1AARfeK+P+99TQ@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------020405080307000605020501"
Subject: Re: [PHP-DEV] Usin ClangStatic Analyzer for zend_parse_parameters
From: ellison.terry@gmail.com (Terry Ellison)

--------------020405080307000605020501
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Julien,
> <snip> Running this over one of my PHP builds I got those error reports:
> http://schlueters.de/zppcheck/ maybe somebody wants to go through them
> and fix at least the trivial ones.
By the way, your report seems to be listing entries twice -- at least as 
the four PHPdbg SAPI ones.  In this case these are all a case of the "s" 
parameter taking a char**, int* but phpdbg.c is passing in a char**, 
uint*.  I'll issue a patch for Joe or Bob to review and push into PHP-5.6.

Note that http://www.php.net/manual/en/internals2.funcs.php states that 
the "s" parameter takes the addresses of char*, uint that is char** 
uint* which is wrong.  Though why the length field should be signed 
seems odd to me as a negative length makes no sense at all.

Regards Terry

--------------020405080307000605020501--