Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:72683 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71439 invoked from network); 18 Feb 2014 11:59:03 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Feb 2014 11:59:03 -0000 Authentication-Results: pb1.pair.com smtp.mail=tjerk.meesters@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=tjerk.meesters@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.174 as permitted sender) X-PHP-List-Original-Sender: tjerk.meesters@gmail.com X-Host-Fingerprint: 209.85.220.174 mail-vc0-f174.google.com Received: from [209.85.220.174] ([209.85.220.174:64997] helo=mail-vc0-f174.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BA/11-65468-50B43035 for ; Tue, 18 Feb 2014 06:59:02 -0500 Received: by mail-vc0-f174.google.com with SMTP id im17so13088980vcb.33 for ; Tue, 18 Feb 2014 03:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=O5ng2H7DvQJDjGbzInGhsVIe5L0Ka/P76d8QFSaQlkk=; b=kUXQAWznEt3nEXwgJjKucK7E/bYbhPFkbV9qWgmgV65jAonekFn7g/AalHuV3VRYaK pDarv65Yif8kHEMK//J1iC8SooiUUgqufayNih85D1cusCKeKi+yqfUGl/P71JwzMxC6 h+aMikfu18qiIM2gU5nNn/TZaerMGw1WL2nmU3/KJOtSM/1WOpHve+jqknYzMrtSAlSF VnMDhpZggw2b5H6mmUhVT6uGoDFE6HnsiqARhUOGzqgQKJG8WFVHYWxAW+7EFHtsapeK Ud5ZKnBv9J4zUZ6DBUMjc6qC8DbifO7yf6dhwt2IlkvAkCuxuhHYmOgthxgX/pP+eM0I E5DQ== MIME-Version: 1.0 X-Received: by 10.52.191.9 with SMTP id gu9mr7509537vdc.37.1392724738789; Tue, 18 Feb 2014 03:58:58 -0800 (PST) Received: by 10.58.133.229 with HTTP; Tue, 18 Feb 2014 03:58:58 -0800 (PST) In-Reply-To: References: Date: Tue, 18 Feb 2014 19:58:58 +0800 Message-ID: To: Yasuo Ohgaki Cc: Damien Tournoud , "internals@lists.php.net" Content-Type: multipart/alternative; boundary=089e013a00ca53564a04f2acff40 Subject: Re: [PHP-DEV] [VOTE] Secure Session Module Options/Internal by Default From: tjerk.meesters@gmail.com (Tjerk Meesters) --089e013a00ca53564a04f2acff40 Content-Type: text/plain; charset=ISO-8859-1 On Tue, Feb 18, 2014 at 7:09 PM, Yasuo Ohgaki wrote: > Hi Tjerk, > > On Tue, Feb 18, 2014 at 7:56 PM, Tjerk Meesters wrote: > >> It seemed to be part of the patch of the respective rfc: >> >> >> https://gist.github.com/yohgaki/1379668#file-php-trunk-strict-session-patch-L602 >> >> How was this a merge issue? >> > > Could you point out what's the exact issue here? > It's gist and it's not the patch merged. > In that case, the RFC should be updated with the corresponding commit logs (part of the process) when it was merged with the project; this makes it easier to discuss historical commits based on it. > tests/session_id_basic.phpt > > var_dump(session_id()); > var_dump(session_id("test")); > var_dump(session_id()); > var_dump(session_id("1234567890")); > var_dump(session_id()); > // Turn off strice mode, since it does not allow uninitialized session ID > ini_set('session.use_strict_mode',false); > var_dump(session_start()); > var_dump(session_id()); > var_dump(session_destroy()); > var_dump(session_id()); > > echo "Done"; > ob_end_flush(); > ?> > --EXPECTF-- > *** Testing session_id() : basic functionality *** > string(0) "" > string(0) "" > string(4) "test" > string(4) "test" > string(10) "1234567890" > bool(true) > string(10) "1234567890" > bool(true) > string(0) "" > Done > > It works like this. Is there issue with this behavior? > That looks okay, thanks for getting back to me :) > > Regards, > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > > -- -- Tjerk --089e013a00ca53564a04f2acff40--