Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72567
Return-Path: <danack@basereality.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 44661 invoked from network); 13 Feb 2014 21:55:19 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 13 Feb 2014 21:55:19 -0000
Authentication-Results: pb1.pair.com header.from=danack@basereality.com; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=danack@basereality.com; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.212.176 cause and error)
X-PHP-List-Original-Sender: danack@basereality.com
X-Host-Fingerprint: 209.85.212.176 mail-wi0-f176.google.com  
Received: from [209.85.212.176] ([209.85.212.176:60766] helo=mail-wi0-f176.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 19/2C-09050-54F3DF25 for <internals@lists.php.net>; Thu, 13 Feb 2014 16:55:19 -0500
Received: by mail-wi0-f176.google.com with SMTP id hi5so9313465wib.3
        for <internals@lists.php.net>; Thu, 13 Feb 2014 13:55:15 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:date:message-id:subject:from:to
         :content-type;
        bh=pNs1LDdUMhaA7WzaSna9enO/n15PlTFxXdgSLeWRafI=;
        b=P2YwwyEHFzl+tt2uA03HKLeNxDKyMvLrfwnvFCtwaeAWGZ6+fjwzCUloBpkSxHeQKD
         2WJs+VXKujHiUCyp2tTObFrrTTTpohljVis/TLUa/8TfdlttlSpfZMvknKDZ2+Ykvt4e
         piuGCbIv2nSOxnw0WPiWIw5fJ0enut8rT0Bn88E5f7tl9REyNxv89JQhagfp8SEGBlkz
         H1Us/xV3VAUVSlnmoo8vbcNsd9ms86kOV4bgFyCd1+48E2YHWrxLfaNaOqEVVeAJq/+8
         KilPqq2NoAaxrJk5T740LfQT/338dfpM/ePdId/nlgOO/OaeNciq0oVIjCfmFHBoHPf7
         3Uww==
X-Gm-Message-State: ALoCoQkRUDVTzTk+MTeMNmDp7SOl2pxQp1l1fq9m5iE5tsT+iWkXKNO2UMrjSZvy2ImHE3mszjge
MIME-Version: 1.0
X-Received: by 10.194.79.131 with SMTP id j3mr3187423wjx.17.1392328514844;
 Thu, 13 Feb 2014 13:55:14 -0800 (PST)
Received: by 10.216.24.195 with HTTP; Thu, 13 Feb 2014 13:55:14 -0800 (PST)
X-Originating-IP: [78.147.8.68]
Date: Thu, 13 Feb 2014 21:55:14 +0000
Message-ID: <CA+kxMuQsoLhGgfPs5QN7tG18+HwM=6x=8W2ijyZ-O0u3BVtOMQ@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: utf-8 filenames in phar files.
From: danack@basereality.com (Dan Ackroyd)

Hi,

I just submitted a PR (https://github.com/php/php-src/pull/588) to
allow utf-8 chars to be included in file names that are put into a
phar file.

I thought I'd ask for feedback here as it would be good to get someone
who understands re2c better than I do, to check the code, as this
seems like such an obvious change, that it's surprising it hasn't been
done before - aka have I missed an obvious reason why it shouldn't be
done?

cheers
Dan