Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72451
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.46 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXYU0+eVgnDCkqpG6AWvLCX9gV3+5nzoeD-RJge8Rtw-dQ@mail.gmail.com>
References: <CAGa2bXYU0+eVgnDCkqpG6AWvLCX9gV3+5nzoeD-RJge8Rtw-dQ@mail.gmail.com>
Date: Mon, 10 Feb 2014 16:29:35 -0800
Message-ID: <CAKOpQSwgg1cRSWq5mB2kOhC45FT4KRHAYUhq9+HFowKcqnLm0w@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0149ce3c073e1104f2168d1e
Subject: Re: [PHP-DEV] [RFC] No PHP tags
From: kris.craig@gmail.com (Kris Craig)

--089e0149ce3c073e1104f2168d1e
Content-Type: text/plain; charset=ISO-8859-1

On Sun, Feb 9, 2014 at 11:35 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi all,
>
> "Optional PHP tags by php.ini and CLI options" RFC has been discussed very
> long time.
>
> https://wiki.php.net/rfc/nophptags
>
> I would like to know is there anyone who would like not to have
> this. I think it's good counter measure for LFI, but you might have
> different perspective.
>
> If it is possible, I would like to address as much as opinions possible
> before voting.
>
> Are there anyone who think we should have this?
> What is the reason?
>
> Thank you
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>

Though I realize I'm in the minority here, I've always supported the idea
of doing something like this.  From an MVC standpoint, it would be nice to
be able to include script-only files.  These scripts would not be able to
include template mode scripts, either.

The main problem is, as others have stated, the fact that it'll be very
prone to human error.  If someone includes a script-only file as template
mode, they'd be dumping the entire source for all the world to see.  The
only way around that-- as far as I can figure, at least-- would be to throw
an exception when including a template mode file that doesn't contain a PHP
open tag.  The problem with that, unfortunately, is that it would almost
certainly cause BC breakage.  That may or may not be acceptable for a major
increment like PHP 6, but certainly not for the 5.x branch.

There's also the usefulness question.  While I agree that it's definitely
not a "must have" feature, I would venture to say it does qualify as a
"would be nice" feature.  Whether or not that merits implementation would
be a matter for debate.  It might be useful to include this in the next
poll we do and see what the larger dev community thinks about this, as it's
something we've debated off-and-on for years now.

--Kris

--089e0149ce3c073e1104f2168d1e--