Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72365
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain bof.de designates 80.242.145.70 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAHMUw2FkBotLPaH67rBVVALiNyW21bSXXHXjgLY4qgefa2CHZw@mail.gmail.com>
References: <CAHMUw2EkBEFnb_Qs1y6xS8AEr6dO48wSAqSWr55W3fRMuumT5Q@mail.gmail.com>
	<CADq_CxrU-nkc-EnBM1T_JQdGfAEAfV8emfKgArsuEZk=LtVBTQ@mail.gmail.com>
	<CAHMUw2G6zeMAcQHDvZL5dWp7jrDQEMQrrCnowYUrCf2fxbo0Ow@mail.gmail.com>
	<CAGAGxbZ-w9RbD0LA_OhpJGB0sU-oJHnLrqenrPz4WqnGBRGAjw@mail.gmail.com>
	<CAHMUw2Eq6Zy1xCV9=-AaqWuSext2u5urf+wT1Rui13A71WQ_Zw@mail.gmail.com>
	<CAGa2bXbk93HE0468XMXAaE1=JLov0PDwmf5G+3v1Bx5Ltyd_vA@mail.gmail.com>
	<CAHMUw2FkBotLPaH67rBVVALiNyW21bSXXHXjgLY4qgefa2CHZw@mail.gmail.com>
Date: Fri, 7 Feb 2014 08:09:51 +0100
Message-ID: <CAJ26g5T3PvAJ_7u2zufQ6g5cZoQU2Qs7XUqipXa82ma4idb3zg@mail.gmail.com>
To: Tjerk Anne Meesters <tjerk.meesters@gmail.com>
Cc: internals <internals@lists.php.net>, Yasuo Ohgaki <yohgaki@ohgaki.net>
Content-Type: multipart/alternative; boundary=001a113a09e81bf96004f1cbad13
Subject: Re: [PHP-DEV] [discussion] add array_usearch()
From: bof@bof.de (Patrick Schaaf)

--001a113a09e81bf96004f1cbad13
Content-Type: text/plain; charset=ISO-8859-1

Hi,

some thoughts on your discussion:

Am 07.02.2014 07:55 schrieb "Tjerk Meesters" <tjerk.meesters@gmail.com>:
>
> That was my first attempt actually; if the first argument is a closure,
use
> that as the search callback. A few problems with that:
> 1) You can't use other types of callback, e.g. string or array.

For that (and possibly other uses), it would be good to have a
cast-to-closure:

$foo = (Closure) 'is_numeric';
$bar = (Closure) [ $that, 'method' ];

That might sometimes even save some work,  when the implementation attempts
to extract the signature of the thing that is to be cast to make a proper
signature for the generated closure. If the callable is then used several
times later (callback in a loop) the callable-as-array-or-string-lookup
would no longer sit in the middle of the loop.

> 2) [bc] You can't search through an array of closures.

That's not good. Could be worked around by using a closure that compares to
the needle closure, but it would still be a BC break.

Code that might be affected would be some kind of registry for lists of
callbacks that, upon insert, wants to check that the thing to be inserted
isn't there already. I wrote something like that two weeks ago,
incidentally :)

In the long run, using an is-closure (not is-callable) vs. is-string branch
in various callback-taking functions, would make for cleaner code, compared
to sprinkling bitmask flag arguments with a DO_IT_CALLBACK_STYLE flag.

best regards
  Patrick

--001a113a09e81bf96004f1cbad13--