Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:72351 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 16651 invoked from network); 6 Feb 2014 23:05:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Feb 2014 23:05:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.181 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.217.181 mail-lb0-f181.google.com Received: from [209.85.217.181] ([209.85.217.181:48350] helo=mail-lb0-f181.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 5B/10-14996-C4514F25 for ; Thu, 06 Feb 2014 18:05:49 -0500 Received: by mail-lb0-f181.google.com with SMTP id z11so1072276lbi.12 for ; Thu, 06 Feb 2014 15:05:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ECviiQSs3iyWURwKI768K2tPKxMWcN+qMGklamtl1e0=; b=k5r1/ZXWX2kIyalRuqdMHUyIhLMr/V9IIxw8bDw0Sp+kcdShNL+rmyZhBjJwI51nfM 96XJjmkFKEMX9aBrWaGEU+4Bi9+uZ6wHtWIF9IQdokTQVC3FlH6ZOwgSheVZ8WQTfHGC k3QYV4gibkd9DrYak/CyOgTf9oAT9jZmKqIr71ZN+A5B5cbJQlj/Dqx6y+VNhpwtUSQq t146vOv/jZcv5xrzMYgIoYZdx7IJ6psysAcVwcLtfCgvSe/+UWJw7XN/NI+4Pfik4Neh DPDCYWwKc+6z6f/aHIkvmykmCFP5/c65qzkfNh+gj7jjOJhEpobOtNS7e3ISFl1CyaZG ctOw== X-Received: by 10.112.131.100 with SMTP id ol4mr3639990lbb.38.1391727945327; Thu, 06 Feb 2014 15:05:45 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.112.199.37 with HTTP; Thu, 6 Feb 2014 15:05:05 -0800 (PST) In-Reply-To: <9E3AA302-1EC1-4497-996F-716555CAAB64@rouvenwessling.de> References: <9E3AA302-1EC1-4497-996F-716555CAAB64@rouvenwessling.de> Date: Fri, 7 Feb 2014 08:05:05 +0900 X-Google-Sender-Auth: iXmjjHrcxA2gbBookBlw0vnjuPg Message-ID: To: =?UTF-8?Q?Rouven_We=C3=9Fling?= Cc: PHP internals Content-Type: multipart/alternative; boundary=047d7b3441b4ce2b3b04f1c4e902 Subject: Re: [PHP-DEV] [VOTE] Timing attack safe string comparison function From: yohgaki@ohgaki.net (Yasuo Ohgaki) --047d7b3441b4ce2b3b04f1c4e902 Content-Type: text/plain; charset=UTF-8 Hi Rouven, I made SipHash version of str_compare() as a sample. There is timing safe php_compare(), which is stolen from BSD. https://github.com/yohgaki/php-src/compare/PHP-5.6-rfc-hash-compare [yohgaki@dev github-php-src]$ ./php-bin -r 'var_dump(str_compare("abc", "abc"));' bool(true) [yohgaki@dev github-php-src]$ ./php-bin -r 'var_dump(str_compare("asfasdf", "slkjojoeiwrj"));' bool(false) It's quick patch made less than 30 min. So it can be improved, I suppose. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net --047d7b3441b4ce2b3b04f1c4e902--