Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72349
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain hotmail.com designates 65.55.111.100 as permitted sender)
Message-ID: <BLU0-SMTP20433536D840DCED3B8DA7AE2940@phx.gbl>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_54B511CA-B2D1-40AE-B684-ABA1237CFA25"
MIME-Version: 1.0 (Mac OS X Mail 7.1 \(1827\))
In-Reply-To: <CAHMUw2FbqmYzGOV28ba6Hrs+zQvdSv1m-5pUkBXeSoJna0XN8w@mail.gmail.com>
Date: Thu, 6 Feb 2014 21:34:44 +0100
CC: Ferenc Kovacs <tyra3l@gmail.com>,
 PHP Internals <internals@lists.php.net>
References: <CAH-PCH5WD2x-qEzexCO2A9oKFZQKPH39ZyoSD08DoxjQwx_Axg@mail.gmail.com> <CAH-PCH5HWa4NipQMgGR+dcRZ1qVPg4k4yPFONM7TZ6K9LcOqiw@mail.gmail.com> <CAHMUw2FbqmYzGOV28ba6Hrs+zQvdSv1m-5pUkBXeSoJna0XN8w@mail.gmail.com>
To: Tjerk Meesters <tjerk.meesters@gmail.com>
Subject: Re: memory leak in the new power operator tests
From: bobwei9@hotmail.com (Bob Weinand)

--Apple-Mail=_54B511CA-B2D1-40AE-B684-ABA1237CFA25
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Am 6.2.2014 um 21:02 schrieb Tjerk Meesters <tjerk.meesters@gmail.com>:
> Hi,
>=20
>=20
> On Fri, Feb 7, 2014 at 12:34 AM, Ferenc Kovacs <tyra3l@gmail.com> =
wrote:
>=20
>=20
>=20
> On Thu, Feb 6, 2014 at 4:40 PM, Ferenc Kovacs <tyra3l@gmail.com> =
wrote:
> Hi,
>=20
> After Bob merged the pow related changes, executing the new tests with =
--enable-debug I've got two memory leaks:
>=20
> [tyrael@Ferencs-MacBook-Pro-135 php-src.git (PHP-5.6.0 =E2=9C=97)]$ =
cat ext/standard/tests/math/pow_variation1_64bit.diff =
ext/standard/tests/math/pow_variation2.diff
> 083+ [Thu Feb  6 16:20:51 2014]  Script:  =
'/Users/tyrael/checkouts/php-src.git/ext/standard/tests/math/pow_variation=
1_64bit.php'
> 084+ /Users/tyrael/checkouts/php-src.git/Zend/zend_API.c(314) :  =
Freeing 0x10D280C50 (72 bytes), =
script=3D/Users/tyrael/checkouts/php-src.git/ext/standard/tests/math/pow_v=
ariation1_64bit.php
> 085+ /Users/tyrael/checkouts/php-src.git/Zend/zend_variables.c(141) : =
Actual location (location was relayed)
> 086+ =3D=3D=3D Total 1 memory leaks detected =3D=3D=3D083+ [Thu Feb  6 =
16:20:51 2014]  Script:  =
'/Users/tyrael/checkouts/php-src.git/ext/standard/tests/math/pow_variation=
2.php'
> 084+ /Users/tyrael/checkouts/php-src.git/Zend/zend_API.c(314) :  =
Freeing 0x10CB8CBE0 (72 bytes), =
script=3D/Users/tyrael/checkouts/php-src.git/ext/standard/tests/math/pow_v=
ariation2.php
> 085+ /Users/tyrael/checkouts/php-src.git/Zend/zend_variables.c(141) : =
Actual location (location was relayed)
> 086+ =3D=3D=3D Total 1 memory leaks detected =3D=3D=3D%
>=20
> not sure if these were originally in the PR or just something went =
wrong with the merge/cherry pick, but would be nice if somebody could =
look into it.
> thanks!
>=20
> --=20
> Ferenc Kov=C3=A1cs
> @Tyr43l - http://tyrael.hu
>=20
> it seems the leak occures when pow() is called with an array:
> [tyrael@Ferencs-MacBook-Pro-135 php-src.git (PHP-5.6.0 =E2=9C=97)]$ =
./sapi/cli/php -r 'pow(array(),2);'
> [Thu Feb  6 17:32:43 2014]  Script:  '-'
> Zend/zend_vm_execute.h(28951) :  Freeing 0x1100B9ED8 (72 bytes), =
script=3D-
> /Users/tyrael/checkouts/php-src.git/Zend/zend_API.c(1011) : Actual =
location (location was relayed)
> =3D=3D=3D Total 1 memory leaks detected =3D=3D=3D
>=20
> Not sure why that didn't pop up earlier; I've attached a patch that =
resolves the memory leak.
>=20
> One gotcha: the output of `pow(0, [])` is now `int(1)` instead of =
`float(1)`. I hope that's alright :)
> =20
>=20
> --=20
> Ferenc Kov=C3=A1cs
> @Tyr43l - http://tyrael.hu
>=20
>=20
>=20
> --=20
> --
> Tjerk
> <php56-pow-memleak.patch.txt>

Your patch wasn't 100% correct, but I corrected that.

I've pushed the fix now.

Bob





--Apple-Mail=_54B511CA-B2D1-40AE-B684-ABA1237CFA25--