Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:72331 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 52819 invoked from network); 6 Feb 2014 09:32:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Feb 2014 09:32:02 -0000 Authentication-Results: pb1.pair.com header.from=rowan.collins@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=rowan.collins@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.173 as permitted sender) X-PHP-List-Original-Sender: rowan.collins@gmail.com X-Host-Fingerprint: 74.125.82.173 mail-we0-f173.google.com Received: from [74.125.82.173] ([74.125.82.173:50661] helo=mail-we0-f173.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DB/00-52146-19653F25 for ; Thu, 06 Feb 2014 04:32:02 -0500 Received: by mail-we0-f173.google.com with SMTP id x55so1086952wes.18 for ; Thu, 06 Feb 2014 01:31:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=NShXsEHpha0E6Q70Sm7InMrMQzwiH0Hv9djcr0vHNI8=; b=SjQKcArVuti5o7nWhr015N0+/ItyTUliwEgAASQTO5GzMNq6Scs3QPGVLHKkjweIH1 SsX7wsGAgrtgbQzndZX06aWf85k0Uh1mi/XZoCZJjPBa17mSRfKU/z2J3jlSYWSNSTdE 9ONaSK/i5fki4JJIzXgdQApttuVvJqZjnSve7Ssv+wahAW5HbUGW79MAgd2YFaXxr844 tFm6CtruXbVw4Mn/e5WaqXvw5Vu+DyEocE9QmjIn1c3Z5XBuH7Dfw6mK+7Uo5r1UTkSm MwZocQIKWVzbtVj7AcWWpAzRAUZyGdBgpSQPO76PBOG7o3tKjzOhWuG6mciEtEikeYwU k5Bw== X-Received: by 10.180.82.193 with SMTP id k1mr20724040wiy.15.1391679117228; Thu, 06 Feb 2014 01:31:57 -0800 (PST) Received: from [192.168.0.138] ([62.189.198.114]) by mx.google.com with ESMTPSA id pm2sm39329015wic.0.2014.02.06.01.31.55 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 06 Feb 2014 01:31:56 -0800 (PST) Message-ID: <52F3568B.5090505@gmail.com> Date: Thu, 06 Feb 2014 09:31:55 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: PHP internals References: <52F00437.7010903@googlemail.com> <52F005E6.6090702@googlemail.com> <52F0D36B.7010905@googlemail.com> <52F29152.3070202@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] [VOTE] __debugInfo() From: rowan.collins@gmail.com (Rowan Collins) Sara Golemon wrote (on 05/02/2014): > Wanna lol? Here's sxe's current implementation of get_debug_info (in > ext/simplexml/simplexml.c) > > static HashTable * sxe_get_debug_info(zval *object, int *is_temp TSRMLS_DC) { > *is_temp = 1; > return sxe_get_prop_hash(object, 1 TSRMLS_CC); > } > > If you can even call that an implementation. :p > > If you're up to improving it, that's the spot to do it. Yeah, I was just pulling that up in lxr. In its defence, the extra 1 is an is_debug parameter which triggers creation of a temporary HashTable instead of a permanently initialised one, and adds an '@attributes' member, so somebody did make *some* effort... I'm still just beginning to get my head round the engine code, so don't hold your breath, but it's definitely something I'd like to help improve... -- Rowan Collins [IMSoP]