Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72290
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.160.51 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <52F29152.3070202@gmail.com>
References: <CAESVnVq3PB+OFXGR+yJ1L2BuX_4+pHyjjvJ8rZXnxexXozyT4A@mail.gmail.com>
	<CAGfRu7Ot_sNhvQY1b18Wb-7UB3uihXsSXPVb=cHhEhA0s4ijVQ@mail.gmail.com>
	<52F00437.7010903@googlemail.com>
	<CAGa2bXanS9VY0j8JQ4oGkEFHmbof-gDmBtpHDMuhMK_K0CEMJg@mail.gmail.com>
	<52F005E6.6090702@googlemail.com>
	<CAGa2bXa-BHmwbyqBQJgoNqoy=CLppJ8GYp2__GGdkpk6UttuMQ@mail.gmail.com>
	<CAGa2bXboT_7rVX7c02hmtYtdjF=_FtX-P7aRT5JFvjEb22JJYg@mail.gmail.com>
	<CAESVnVrRsByJ00xU+R35aSH8KF6Xa14O2_weTUGEY5t20+HTtg@mail.gmail.com>
	<52F0D36B.7010905@googlemail.com>
	<CAESVnVrrhveh1p2afcd4ov+jry6wnZB=NkEO_Nxq6B7pj0=_Tg@mail.gmail.com>
	<52F29152.3070202@gmail.com>
Date: Wed, 5 Feb 2014 12:01:49 -0800
Message-ID: <CAESVnVrVzs38RYGRQYQ1ZXFfKGvgebfmhsMWQJOPPe8zy4p1+g@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [RFC] [VOTE] __debugInfo()
From: pollita@php.net (Sara Golemon)

On Wed, Feb 5, 2014 at 11:30 AM, Rowan Collins <rowan.collins@gmail.com> wrote:
> Sara Golemon wrote (on 05/02/2014):
>> (such as current uses in dom,
>> sxe, mysqli, intl, and spl)
>
> If "sxe" in there means SimpleXML, I wish it would do a better job of it!
>
Yes, sxe is short for SimpleXML. :)

> In fact, now that I know this hook exists, and doesn't affect the action of
> array casts, I'm tempted to attempt a patch that would improve it, based on
> the simplexml_tree function I've written at
> https://github.com/IMSoP/simplexml_debug
>
Wanna lol? Here's sxe's current implementation of get_debug_info (in
ext/simplexml/simplexml.c)

static HashTable * sxe_get_debug_info(zval *object, int *is_temp TSRMLS_DC) {
  *is_temp = 1;
  return sxe_get_prop_hash(object, 1 TSRMLS_CC);
}

If you can even call that an implementation. :p

If you're up to improving it, that's the spot to do it.

-Sara