Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72279
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.179 as permitted sender)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
In-Reply-To: <CAGa2bXaP0V_aChGipAUvJYhmO2Qugr0HOo3kTY1P2A+=rmyNnA@mail.gmail.com>
References: <CAESVnVq3PB+OFXGR+yJ1L2BuX_4+pHyjjvJ8rZXnxexXozyT4A@mail.gmail.com>
 <CAGfRu7Ot_sNhvQY1b18Wb-7UB3uihXsSXPVb=cHhEhA0s4ijVQ@mail.gmail.com>
 <52F00437.7010903@googlemail.com> <CAGa2bXanS9VY0j8JQ4oGkEFHmbof-gDmBtpHDMuhMK_K0CEMJg@mail.gmail.com>
 <52F005E6.6090702@googlemail.com> <CAGa2bXa-BHmwbyqBQJgoNqoy=CLppJ8GYp2__GGdkpk6UttuMQ@mail.gmail.com>
 <CAGa2bXboT_7rVX7c02hmtYtdjF=_FtX-P7aRT5JFvjEb22JJYg@mail.gmail.com>
 <CAESVnVrRsByJ00xU+R35aSH8KF6Xa14O2_weTUGEY5t20+HTtg@mail.gmail.com>
 <52F0D36B.7010905@googlemail.com> <CAHMUw2GdXC6ymrpiA=QXQbfzDTssVKDOVh3SXXPO29owHW9u6A@mail.gmail.com>
 <CAGa2bXaP0V_aChGipAUvJYhmO2Qugr0HOo3kTY1P2A+=rmyNnA@mail.gmail.com>
Date: Wed, 5 Feb 2014 18:05:24 +0100
Message-ID: <CAMUwpuSNm2okC=YvSMabnHNNLr7MNTCYjAS8JYBruWBE1+aQRA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Tjerk Meesters <tjerk.meesters@gmail.com>, 
	Crypto Compress <cryptocompress@googlemail.com>, Sara Golemon <pollita@php.net>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [RFC] [VOTE] __debugInfo()
From: jpauli@php.net (Julien Pauli)

On Wed, Feb 5, 2014 at 1:24 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi all,
>
> On Tue, Feb 4, 2014 at 10:16 PM, Tjerk Meesters <tjerk.meesters@gmail.com>wrote:
>
>> > some more questions:
>> >
>> > 1. Can this hook be bypassed or disabled (global/temporary)?
>> > e.g. real_var_dump(), ini setting, some other flag?
>> >
>> > 2. What will be affected by this hook beside "var_dump"?
>> > e.g. xdebug output, var_export, ...
>> >
>> > 3. How would this behave (segfault?):
>> > public function __debugInfo() { var_dump($this); return []; }
>> >
>>
>> Yeah, there doesn't seem to be any recursion protection, just like:
>>
>> public function __toString() { return (string)$this; }
>
>
> It is the same as
>
> function f() {
>   f();
> }
>
> User may do that, but it's a documentation problem.
> It would be not obvious as function call recursion.
> and must be documented, probably.

Yup, AFAIK, the only recursion calls we check against are in __get()
and __set() handlers, that's all.

I admit the __tostring() casting $this to string is tricky ;-)

I suggest we dont implement recursion checks for debug_info neither.

Julien.P