Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72246
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.43 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <52F1E58F.3050105@sugarcrm.com>
References: <52EE2B66.4040005@pthreads.org> <CAGa2bXYJT+qXRXinxd_hqgPG0UfWkvCH0f6sgLyzSjM2X57j0g@mail.gmail.com>
 <CALtuQzAt_FaZwQpfJM9ed1JJSQAWb2bgP=R+hQfnVkZxZLpREw@mail.gmail.com>
 <CAGa2bXa5zON7-A6LST7yyWBrJ8ZKP7eeSSiQM-DpqNbOnrdveA@mail.gmail.com>
 <52F157BE.3020804@ajf.me> <CAGa2bXafeGSQ1X7TUsQYnnASqyBPjyT1nh=yPM9LdbW3nY3Gmg@mail.gmail.com>
 <52F15FD6.7060901@ajf.me> <CAGa2bXZvEN0KULW3MBR6y+wFKDiHOw7dXqsBeMZVYNNAXXYg2A@mail.gmail.com>
 <CAGa2bXYLkvdPXGcC=G93EKQPUBxCCKLcx-FHUK3Kt8NasD5Cvw@mail.gmail.com> <52F1E58F.3050105@sugarcrm.com>
Date: Wed, 5 Feb 2014 16:44:41 +0900
Message-ID: <CAGa2bXanYKsciVPwu30SA0HvHWDRJhv5AcG-B00+2h=fq_CUfg@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c36c9459b0c404f1a3f0b6
Subject: Re: [PHP-DEV] RE: RFC: expectations/assertions
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c36c9459b0c404f1a3f0b6
Content-Type: text/plain; charset=UTF-8

Hi all,

On Wed, Feb 5, 2014 at 4:17 PM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> >> php > assert('function() {return FALSE;}');
> >> php > assert('function() {return TRUE;}');
>
> This runs function() code, which produces a closure. The closure is not
> false, so assert is not fired.
>
> >> php > assert(eval('function() {return FALSE;};'));
>
> The eval here returns NULL (http://3v4l.org/cPpgj) so of course assert
> will be fired here. From eval's manual:
> eval() returns NULL unless return is called in the evaluated code, in
> which case the value passed to return is returned.
> Compare:
> http://3v4l.org/vhe1p
> http://3v4l.org/B79r3


Thank you.
It looks I did wrong on my little experiment.


> >> Warning: assert(): Assertion failed in php shell code on line 1
> >>
> >> so closure in eval() works. I don't see reason not to allow closure
>
> Did you try:
> assert(eval('function() {return TRUE;};'));
>
> Testing hypothesis usually involves not only testing something that
> confirms it, but also something that may refute it. Otherwise you're not
> really testing, you are just convincing yourself.
>
> > Added this to inconsistent behaviors RFC to track.
> >
> > https://wiki.php.net/rfc/inconsistent-behaviors#assert
>
> There's no inconsistent behaviors here and IMHO this RFC is turning into
> "things people misunderstand in PHP". Maybe it should be moved to a blog
> or some other space, because it by now has very little to do with what
> RFCs are for.


function func() {}
assert(func());

and

assert(function func() {});

would be better to get the same result. Besides, rather than

$f = function func() {};
assert($f());

This form

assert(function func() {
  // some code here
});

is more user friendly and looks more modern language.
I'm sure most users are used to latter form, since this form
is used extensively in JavaScript. It keeps variable scope
clean, too.

I hope new assert() supports direct closure call :)

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c36c9459b0c404f1a3f0b6--