Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:72223
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.173 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <52F15FD6.7060901@ajf.me>
References: <52EE2B66.4040005@pthreads.org> <CAGa2bXYJT+qXRXinxd_hqgPG0UfWkvCH0f6sgLyzSjM2X57j0g@mail.gmail.com>
 <CALtuQzAt_FaZwQpfJM9ed1JJSQAWb2bgP=R+hQfnVkZxZLpREw@mail.gmail.com>
 <CAGa2bXa5zON7-A6LST7yyWBrJ8ZKP7eeSSiQM-DpqNbOnrdveA@mail.gmail.com>
 <52F157BE.3020804@ajf.me> <CAGa2bXafeGSQ1X7TUsQYnnASqyBPjyT1nh=yPM9LdbW3nY3Gmg@mail.gmail.com>
 <52F15FD6.7060901@ajf.me>
Date: Wed, 5 Feb 2014 07:53:17 +0900
Message-ID: <CAGa2bXZvEN0KULW3MBR6y+wFKDiHOw7dXqsBeMZVYNNAXXYg2A@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: Sebastian Krebs <krebs.seb@gmail.com>, Joe Watkins <pthreads@pthreads.org>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c24896ee1dd904f19c8365
Subject: Re: [PHP-DEV] RE: RFC: expectations/assertions
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

--001a11c24896ee1dd904f19c8365
Content-Type: text/plain; charset=UTF-8

On Wed, Feb 5, 2014 at 6:47 AM, Andrea Faulds <ajf@ajf.me> wrote:

> On 04/02/14 21:30, Yasuo Ohgaki wrote:
>
>> eval() works.
>>
>> php > assert(eval('FALSE;'));
>>
>> Warning: assert(): Assertion failed in php shell code on line 1
>> php > assert(eval('return FALSE;'));
>>
>> Warning: assert(): Assertion failed in php shell code on line 1
>> php >
>>
>> However, it does not solve inconsistency. PHP code has to be string.
>> Writing PHP code as string is not fun thing to do ;)
>>
>
> That's not what I meant. At present, you do:
>
>     assert($string);
>
> And that string is evaluated. A closure would be faster. Though this is
> for debugging code, so I'm not sure it matters (though I, unlike some
> people, might like to use assertions in production code to make sure things
> fail early, fail often).


I think I understood your comment.

php > assert('function() {return FALSE;}');
php > assert('function() {return TRUE;}');

It does not work, but

php > assert(eval('function() {return FALSE;};'));

Warning: assert(): Assertion failed in php shell code on line 1

so closure in eval() works. I don't see reason not to allow closure
directly.
It only seems inconsistent to me.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net

--001a11c24896ee1dd904f19c8365--